You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2023/05/04 16:15:04 UTC
[Impala-ASF-CR] aarch64: define FORCE INLINE once
spop@amazon.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19839
Change subject: aarch64: define FORCE_INLINE once
......................................................................
aarch64: define FORCE_INLINE once
Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
---
M be/src/util/sse2neon.h
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/19839/1
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
[Impala-ASF-CR] IMPALA-12119: define FORCE INLINE only once
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has removed a vote on this change.
Change subject: IMPALA-12119: define FORCE_INLINE only once
......................................................................
Removed Code-Review+2 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9303/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 22:42:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Michael Smith, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19839
to look at the new patch set (#6).
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
IMPALA-12119: rename FORCE_INLINE to avoid name collision
Compiling impala on arm64 fails with an error of redefined FORCE_INLINE
preprocessor macro:
/home/spop/impala/be/src/util/sse2neon.h:48: error: "FORCE_INLINE" redefined [-Werror]
48 | #define FORCE_INLINE static inline {}attribute{}((always_inline))
|
In file included from /home/spop/impala/be/src/codegen/llvm-codegen-cache.h:30,
from /home/spop/impala/be/src/runtime/exec-env.cc:27:
/home/spop/impala/be/src/thirdparty/datasketches/MurmurHash3.h:45: note: this is the location of the previous definition
45 | #define FORCE_INLINE inline {}attribute{}((always_inline))
|
This patch renames FORCE_INLINE in MurmurHash3.h following the patch
in datasketches:
https://github.com/apache/datasketches-cpp/commit/0d8a17de0dc18493eb17e6613ad1534d6ff247b7
Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
---
M be/src/thirdparty/datasketches/MurmurHash3.h
1 file changed, 24 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/19839/6
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] aarch64: define FORCE INLINE once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: aarch64: define FORCE_INLINE once
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12934/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 May 2023 16:35:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: define FORCE INLINE only once
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
spop@amazon.com has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: define FORCE_INLINE only once
......................................................................
IMPALA-12119: define FORCE_INLINE only once
Compiling impala on arm64 fails with an error of redefined FORCE_INLINE
preprocessor macro:
/home/spop/impala/be/src/util/sse2neon.h:48: error: "FORCE_INLINE" redefined [-Werror]
48 | #define FORCE_INLINE static inline {}attribute{}((always_inline))
|
In file included from /home/spop/impala/be/src/codegen/llvm-codegen-cache.h:30,
from /home/spop/impala/be/src/runtime/exec-env.cc:27:
/home/spop/impala/be/src/thirdparty/datasketches/MurmurHash3.h:45: note: this is the location of the previous definition
45 | #define FORCE_INLINE inline {}attribute{}((always_inline))
|
This patch guards the definition of FORCE_INLINE in sse2neon.h to avoid
re-defining it.
Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
---
M be/src/util/sse2neon.h
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/19839/5
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
IMPALA-12119: rename FORCE_INLINE to avoid name collision
Compiling impala on arm64 fails with an error of redefined FORCE_INLINE
preprocessor macro:
/home/spop/impala/be/src/util/sse2neon.h:48: error: "FORCE_INLINE" redefined [-Werror]
48 | #define FORCE_INLINE static inline {}attribute{}((always_inline))
|
In file included from /home/spop/impala/be/src/codegen/llvm-codegen-cache.h:30,
from /home/spop/impala/be/src/runtime/exec-env.cc:27:
/home/spop/impala/be/src/thirdparty/datasketches/MurmurHash3.h:45: note: this is the location of the previous definition
45 | #define FORCE_INLINE inline {}attribute{}((always_inline))
|
This patch renames FORCE_INLINE in MurmurHash3.h following the patch
in datasketches:
https://github.com/apache/datasketches-cpp/commit/0d8a17de0dc18493eb17e6613ad1534d6ff247b7
Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Reviewed-on: http://gerrit.cloudera.org:8080/19839
Reviewed-by: Daniel Becker <da...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/thirdparty/datasketches/MurmurHash3.h
1 file changed, 24 insertions(+), 27 deletions(-)
Approvals:
Daniel Becker: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] aarch64: define FORCE INLINE once
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
spop@amazon.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: aarch64: define FORCE_INLINE once
......................................................................
Patch Set 1:
> Is there some other definition interfering
> with it?
Yes, here's the error message showing the other place that defines it first:
```
In file included from /home/spop/impala/be/src/codegen/llvm-codegen-cache.h:30,
from /home/spop/impala/be/src/runtime/exec-env.cc:27:
/home/spop/impala/be/src/thirdparty/datasketches/MurmurHash3.h:45: note: this is the location of the previous definition
45 | #define FORCE_INLINE inline __attribute__((always_inline))
```
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 May 2023 20:11:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
Patch Set 6:
The test failures are unrelated to this change, restarting test job.
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 22:42:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: define FORCE INLINE only once
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has removed a vote on this change.
Change subject: IMPALA-12119: define FORCE_INLINE only once
......................................................................
Removed Verified+1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] aarch64: define FORCE INLINE once
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: aarch64: define FORCE_INLINE once
......................................................................
Patch Set 1: Code-Review+1
This looks reasonable. Is there some other definition interfering with it?
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 May 2023 16:44:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] aarch64: define FORCE INLINE once
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: aarch64: define FORCE_INLINE once
......................................................................
Patch Set 1:
Thanks @sebpop for fixing this. Could you open a Jira ticket for this change? Then you should reference the Jira ticket in the commit message title and also briefly describe the problem and how it is solved in the commit message. You can take this as an example: https://gerrit.cloudera.org/#/c/19834/
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 09:25:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
Patch Set 6: Code-Review+2
This looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 16:21:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 09:17:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 May 2023 03:58:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12974/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 May 2023 15:14:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: define FORCE INLINE only once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: define FORCE_INLINE only once
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12967/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 May 2023 20:44:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9301/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 16:27:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9301/
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 21:47:44 +0000
Gerrit-HasComments: No