[jira] [Issue Comment Deleted] (HADOOP-13280) FileSystemStorageStatistics#getLong(“readOps“) should return readOps + largeReadOps

["Mingliang Liu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-13280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mingliang Liu updated HADOOP-13280:
-----------------------------------
    Comment: was deleted

(was: Thanks [~cmccabe] for the explanation. I find "readOps", "largeReadOps" and "writeOps" all use the same approach {{Long.valueOf( readOps + largeReadOps)}}. I think we can stick to this. For coding style consistency, I can prepare an updated patch very soon.)

> FileSystemStorageStatistics#getLong(“readOps“) should return readOps + largeReadOps
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-13280
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13280
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-13280-branch-2.8.000.patch, HADOOP-13280.000.patch, HADOOP-13280.001.patch
>
>
> Currently {{FileSystemStorageStatistics}} instance simply returns data from {{FileSystem$Statistics}}. As to {{readOps}}, the {{FileSystem$Statistics#getReadOps()}} returns {{readOps + largeReadOps}}. We should make the {{FileSystemStorageStatistics#getLong(“readOps“)}} return the sum as well.
> Moreover, there is no unit tests for {{FileSystemStorageStatistics}} and this JIRA will also address this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org