You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2020/10/21 16:07:38 UTC
[GitHub] [incubator-teaclave-sgx-sdk] Ruide commented on a change in pull request #274: Sqlite3 Port
Ruide commented on a change in pull request #274:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/274#discussion_r509415517
##########
File path: samplecode/sqlite3/enclave/Enclave.edl
##########
@@ -32,27 +32,6 @@ enclave {
void ocall_print_error([in, string] const char *str);
void ocall_print_string([in, string] const char *str);
void ocall_println_string([in, string] const char *str);
-
- int ocall_lstat([in, string] const char *path, [in, out, size=size] struct stat *buf, size_t size) propagate_errno;
- int ocall_stat([in, string] const char *path, [in, out, size=size] struct stat *buf, size_t size);
- int ocall_fstat(int fd, [in, out, size=size] struct stat* buf, size_t size);
- int ocall_ftruncate(int fd, off_t length);
-
- char* ocall_getcwd([out, size=size] char *buf, size_t size) propagate_errno;
- int ocall_getpid(void);
- int ocall_getuid(void);
- char* ocall_getenv([in, string] const char *name);
-
- int ocall_open64([in, string] const char *filename, int flags, mode_t mode);
- int ocall_close(int fd);
- off_t ocall_lseek64(int fd, off_t offset, int whence) propagate_errno;
- int ocall_read(int fd, [out, size=count] void *buf, size_t count) propagate_errno;
- int ocall_write(int fd, [in, size=count] const void *buf, size_t count) propagate_errno;
- int ocall_fsync(int fd);
- int ocall_fcntl(int fd, int cmd, [in, size=size] void* arg, size_t size) propagate_errno;
- int ocall_unlink([in, string] const char *pathname);
- int ocall_fchmod(int fd, mode_t mode);
- int ocall_fchown(int fd, uid_t owner, gid_t group);
Review comment:
Clean up all the ocall syscalls for security concern mentioned by @mssun. Although only support in-memory SQLite database now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org