You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/26 20:30:00 UTC
[jira] [Commented] (MAHOUT-1994) Remove ViennCL jars upon mvn
clean.
[ https://issues.apache.org/jira/browse/MAHOUT-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063714#comment-16063714 ]
ASF GitHub Bot commented on MAHOUT-1994:
----------------------------------------
GitHub user andrewpalumbo opened a pull request:
https://github.com/apache/mahout/pull/328
MAHOUT-1994: clean viennacl jars on 'mvn clean -Pviennacl -Phadoop2'
### Purpose of PR:
Please give a short description of what this PR is for.
### Important ToDos
Please mark each with an "x"
- [x ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [x ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests pass locally.
If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
Does this change break earlier versions?
Is this the beginning of a larger project for which a feature branch should be made?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewpalumbo/mahout MAHOUT-1994
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mahout/pull/328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #328
----
commit eaa54ad64dd9920b52ff255f802c3a0913f0c487
Author: Andrew Palumbo <ap...@apache.org>
Date: 2017-06-26T20:27:11Z
clean viennacl jars on 'mvn clean -Pviennacl -Phadoop2'
----
> Remove ViennCL jars upon mvn clean.
> -----------------------------------
>
> Key: MAHOUT-1994
> URL: https://issues.apache.org/jira/browse/MAHOUT-1994
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.13.0
> Reporter: Andrew Palumbo
> Assignee: Andrew Palumbo
> Priority: Blocker
> Fix For: 0.13.1
>
>
> currently, after running `mvn clean` from $MAHOUT_HOME, VinenaCL jars are not removed from the base level directory.
> add in something similar to:
> {code}
> <plugin>
> <artifactId>maven-clean-plugin</artifactId>
> <version>3.0.0</version>
> <configuration>
> <filesets>
> <fileset>
> <directory>../</directory>
> <includes>
> <include>mahout-spark*.jar</include>
> </includes>
> <followSymlinks>false</followSymlinks>
> </fileset>
> </filesets>
> </configuration>
> </plugin>
> </plugins>
> </build>
> {code}
> in both {{vienncl}} and {{viennacl-omp}} module pom.xmls
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)