[GitHub] [systemds] BACtaki commented on a diff in pull request #1677: [SYSTEMDS-3413] Add support for row/col aggregation to countDistinct builtin function

[GitBox <gi...@apache.org>]

BACtaki commented on code in PR #1677:
URL: https://github.com/apache/systemds/pull/1677#discussion_r1002844611


##########
src/main/java/org/apache/sysds/runtime/instructions/InstructionUtils.java:
##########
@@ -420,7 +421,11 @@ else if ( opcode.equalsIgnoreCase("uacmin") ) {
 			AggregateOperator agg = new AggregateOperator(Double.POSITIVE_INFINITY, Builtin.getBuiltinFnObject("min"));
 			aggun = new AggregateUnaryOperator(agg, ReduceRow.getReduceRowFnObject(), numThreads);
 		}
-		
+		else if ( opcode.equalsIgnoreCase("uacd") || opcode.equalsIgnoreCase("uacdr")
+				|| opcode.equalsIgnoreCase("uacdc") ) {

Review Comment:
   I have added them in a separate "section" for sketch operators:
   ```
   		String2SPInstructionType.put( "uacd"    , SPType.AggregateUnary);
   		String2SPInstructionType.put( "uacdr"   , SPType.AggregateUnary);
   		String2SPInstructionType.put( "uacdc"   , SPType.AggregateUnary);
   
   		// Aggregate unary sketch operators
   		String2SPInstructionType.put( "uacdap" , SPType.AggregateUnarySketch);
   		String2SPInstructionType.put( "uacdapr", SPType.AggregateUnarySketch);
   		String2SPInstructionType.put( "uacdapc", SPType.AggregateUnarySketch);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org