You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "ketor (via GitHub)" <gi...@apache.org> on 2024/08/27 15:56:13 UTC
[PR] Implement rwlock in bthread. (brpc)
ketor opened a new pull request, #2748:
URL: https://github.com/apache/brpc/pull/2748
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
实现brpc中缺失的rwlock
Side effects:
- Performance effects(性能影响):
- Breaking backward compatibility(向后兼容性):
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Implement rwlock in bthread. (brpc)
Posted by "ketor (via GitHub)" <gi...@apache.org>.
ketor closed pull request #2748: Implement rwlock in bthread.
URL: https://github.com/apache/brpc/pull/2748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Implement rwlock in bthread. (brpc)
Posted by "ketor (via GitHub)" <gi...@apache.org>.
ketor commented on PR #2748:
URL: https://github.com/apache/brpc/pull/2748#issuecomment-2333053486
> 跟#1031 的实现一样？
>
> > 这个实现性能有很大优化吧。这个无脑 butex 唤醒有问题吧？理想状态下应该有个 flag 标识有没有真的有 bthread 在等待。
>
> [这个问题](https://github.com/apache/brpc/pull/1031#issuecomment-831419766)解决了吗？
好像是差不多的。看起来你已经在实现了，这个PR可以关掉了。现在在开发的项目是编译时给brpc打patch实现rwlock的，所以希望brpc能内置rwlock的实现。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org