You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "ibsidorenko (via GitHub)" <gi...@apache.org> on 2023/03/29 15:08:59 UTC
[GitHub] [tvm] ibsidorenko opened a new pull request, #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
ibsidorenko opened a new pull request, #14427:
URL: https://github.com/apache/tvm/pull/14427
Update assert during buffer allocation. Zero dimensional tensors (scalars) can have a null shape.
This PR is attempt to port [PR#14376](https://github.com/apache/tvm/pull/14376) from tvm/main that enables Hexagon tests with Relax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14427:
URL: https://github.com/apache/tvm/pull/14427#issuecomment-1489162287
Can we wait for the next rebase instead of making the same change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] farshidsp commented on pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
Posted by "farshidsp (via GitHub)" <gi...@apache.org>.
farshidsp commented on PR #14427:
URL: https://github.com/apache/tvm/pull/14427#issuecomment-1488867429
Thanks for this PR. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14427:
URL: https://github.com/apache/tvm/pull/14427#issuecomment-1490424009
yes, we plan to do it sometime this weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ibsidorenko commented on pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
Posted by "ibsidorenko (via GitHub)" <gi...@apache.org>.
ibsidorenko commented on PR #14427:
URL: https://github.com/apache/tvm/pull/14427#issuecomment-1489189256
> Can we wait for the next rebase instead of making the same change?
Sure, we can wait If rebase is planned in the near future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen closed pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen closed pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
URL: https://github.com/apache/tvm/pull/14427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14427:
URL: https://github.com/apache/tvm/pull/14427#issuecomment-1493112809
should be in now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14427:
URL: https://github.com/apache/tvm/pull/14427#issuecomment-1488813467
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ibsidorenko commented on pull request #14427: [Unity][Hexagon] Allow scalar tensors to have null shape during allocation
Posted by "ibsidorenko (via GitHub)" <gi...@apache.org>.
ibsidorenko commented on PR #14427:
URL: https://github.com/apache/tvm/pull/14427#issuecomment-1488827064
cc @csullivan @farshidsp @janetsc @tqchen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org