[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #141: Ignore the previous job_id inside fill_reservations()

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #141:
URL: https://github.com/apache/arrow-ballista/pull/141#discussion_r947393323


##########
ballista/rust/scheduler/src/state/execution_graph.rs:
##########
@@ -381,11 +381,21 @@ impl ExecutionPlanVisitor for ExecutionStageBuilder {
         } else if let Some(unresolved_shuffle) =
             plan.as_any().downcast_ref::<UnresolvedShuffleExec>()
         {
-            self.output_links
-                .insert(unresolved_shuffle.stage_id, self.current_stage_id);
+            if let Some(output_links) =
+                self.output_links.get_mut(&unresolved_shuffle.stage_id)
+            {
+                if !output_links.contains(&self.current_stage_id) {

Review Comment:
   Would it be better to make `output_links` a `HashSet` instead of a `Vec`, given that duplicate values are not allowed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org