You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/08 20:11:22 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #28234: Make arguments 'offset' and 'length' not required

eladkal commented on code in PR #28234:
URL: https://github.com/apache/airflow/pull/28234#discussion_r1043784072


##########
airflow/providers/microsoft/azure/hooks/wasb.py:
##########
@@ -385,7 +385,7 @@ def upload(
         return blob_client.upload_blob(data, blob_type, length=length, **kwargs)
 
     def download(
-        self, container_name, blob_name, offset: int, length: int, **kwargs
+        self, container_name, blob_name, offset: int | None = None, length: int | None = None, **kwargs

Review Comment:
   This is what we had before https://github.com/apache/airflow/pull/25426
   we needed to make the change to update to newer sdk version
   see https://github.com/apache/airflow/pull/25426#issuecomment-1233152203



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org