[GitHub] [pulsar] codelipenghui commented on a change in pull request #7139: Support KeyValue Schema Use Null Key And Null Value

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #7139:
URL: https://github.com/apache/pulsar/pull/7139#discussion_r434924022



##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -143,6 +143,9 @@ message MessageMetadata {
 	optional int32 num_chunks_from_msg = 27;
 	optional int32 total_chunk_msg_size = 28;
 	optional int32 chunk_id = 29;
+
+    // Indicate if the message key is set
+    optional bool null_key = 30 [default = false];

Review comment:
       It's better to use null_partition_key here since we have partition_key and ordering key in the proto. Use null_partition_key will be more accurate.

##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -161,6 +164,8 @@ message SingleMessageMetadata {
     optional uint64 sequence_id = 8;
     // Indicate if the message payload value is set
     optional bool null_value = 9 [ default = false ];
+    // Indicate if the message key is set
+    optional bool null_key = 10 [ default = false];

Review comment:
       Same as the above comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org