[jira] Commented: (DIRMINA-145) filter for writing streams

["Niklas Therning (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/DIRMINA-145?page=comments#action_12360627 ] 

Niklas Therning commented on DIRMINA-145:
-----------------------------------------

I've applied the attached patch and made some minor changes to make it more generic. The changes are:

* The filter will now call nextFilter.messageSent once all the contents of the stream has been written. 
* The filter won't close the stream. The IoHandler will have to take care of this in messageSent. 
* The filter will throw IllegalStateException if one tries to write something while there's a stream being worked on. 
* The advances property has been changed into a writeBufferSize property. I think that will make more sense to users.

I hope these changes are ok and that they will make the filter even more useful. I will check it into subversion as soon as I have updated the test.

Thank you, Johannes, for your contribution!


> filter for writing streams
> --------------------------
>
>          Key: DIRMINA-145
>          URL: http://issues.apache.org/jira/browse/DIRMINA-145
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Johannes Zillmann
>     Assignee: Niklas Therning
>  Attachments: streamWriteFilter.zip
>
> a filter for easy stream writing would be usefull.
> I append a zip with that kind of filter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira