You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by dp...@apache.org on 2018/09/11 16:58:45 UTC
[cordova-cli] branch master updated: GH-320 Remove support for
browserify
This is an automated email from the ASF dual-hosted git repository.
dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
The following commit(s) were added to refs/heads/master by this push:
new 7fc2707 GH-320 Remove support for browserify
7fc2707 is described below
commit 7fc270700bda4ae66913e276df631a8c7d63a657
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Tue Sep 11 12:37:09 2018 +0200
GH-320 Remove support for browserify
---
doc/build.txt | 5 +----
doc/config.txt | 6 ------
doc/plugin.txt | 10 ++++------
doc/prepare.txt | 6 +-----
doc/readme.md | 13 ++-----------
doc/run.txt | 3 ---
spec/cli.spec.js | 12 ++++++------
src/cli.js | 7 -------
8 files changed, 14 insertions(+), 48 deletions(-)
diff --git a/doc/build.txt b/doc/build.txt
index f3eb356..3245804 100644
--- a/doc/build.txt
+++ b/doc/build.txt
@@ -20,12 +20,9 @@ all/the specified platforms.
--buildConfig....................... Use the specified build configuration
instead of default build.json
- --browserify ....................... Compile plugin JS at build time using
- browserify instead of runtime.
-
To provide platform specific options, you must include them after `--`.
Example
cordova-cli build android windows --debug --device
cordova-cli build android --release --buildConfig=..\myBuildConfig.json
- cordova-cli build android --release -- --keystore="..\android.keystore" --storePassword=android --alias=mykey
\ No newline at end of file
+ cordova-cli build android --release -- --keystore="..\android.keystore" --storePassword=android --alias=mykey
diff --git a/doc/config.txt b/doc/config.txt
index 2b0b35f..af116fc 100644
--- a/doc/config.txt
+++ b/doc/config.txt
@@ -24,11 +24,5 @@ Options
Allows the user to set save to true or false when adding platforms or plugins.
When false, platforms/plugins are not saved to `config.xml` and `package.json`.
- browserify ...................... default setting = false
- Allows the user to use the browserify module to bundle the JavaScript files of
- the included plugins at build time versus our traditional run time loading of
- those files.
-
Examples
cordova config set autosave false
- cordova config set browserify true
diff --git a/doc/plugin.txt b/doc/plugin.txt
index 0915eea..8262f69 100644
--- a/doc/plugin.txt
+++ b/doc/plugin.txt
@@ -4,7 +4,7 @@ Synopsis
Manage project plugins
- add <plugin-spec> [...] ............ Add specified plugins and save them to
+ add <plugin-spec> [...] ............ Add specified plugins and save them to
config.xml & package.json.
--searchpath <directory> ....... When looking up plugins by ID, look in this directory and
each of its subdirectories before hitting the registry.
@@ -15,18 +15,16 @@ Manage project plugins
--link ......................... When installing from a local path, creates a symbolic link
instead of copying files. The extent to which files are linked
varies by platform. Useful for plugin development.
- --nosave ....................... Prevent saving the information for specified plugin
+ --nosave ....................... Prevent saving the information for specified plugin
into config.xml & package.json.
--shrinkwrap ................... Used together with --save, saves the
installed version numbers to config.xml
- --browserify ................... Compile plugin JS at build time using
- browserify instead of runtime.
--force ........................ Forces copying source files from the plugin even if the
same file already exists in the target directory.
-
- remove <pluginid>|<name> [...] ..... Remove plugins with the given IDs/name and
+
+ remove <pluginid>|<name> [...] ..... Remove plugins with the given IDs/name and
removes the information for specified plugin from config.xml & package.json.
--nosave ....................... Prevents removing the information for
specified plugin from config.xml & package.json.
diff --git a/doc/prepare.txt b/doc/prepare.txt
index 984f86a..fee2d56 100644
--- a/doc/prepare.txt
+++ b/doc/prepare.txt
@@ -5,9 +5,5 @@ Synopsis
Copies files for specified platforms, or all platforms,
so that the project is ready to build with each SDK.
-Options
- --browserify .............................. Compile plugin JS at build time using
- browserify instead of runtime.
-
Example
- cordova-cli prepare --browserify
\ No newline at end of file
+ cordova-cli prepare
diff --git a/doc/readme.md b/doc/readme.md
index bb8dfd1..046470d 100644
--- a/doc/readme.md
+++ b/doc/readme.md
@@ -83,7 +83,7 @@ Certain commands have options (`platformOpts`) that are specific to a particular
cd myApp
# Add camera plugin to the project and remember that in config.xml & package.json.
cordova plugin add cordova-plugin-camera
- # Add camera plugin to the project and remember that in config.xml and package.json.
+ # Add camera plugin to the project and remember that in config.xml and package.json.
cordova plugin add cordova-plugin-camera
# Add android platform to the project and remember that in config.xml & package.json.
cordova platform add android
@@ -310,7 +310,7 @@ Manage project plugins
```bash
cordova {plugin | plugins} [
- add <plugin-spec> [..] {--searchpath=<directory> | --noregistry | --link | --save | --browserify | --force} |
+ add <plugin-spec> [..] {--searchpath=<directory> | --noregistry | --link | --save | --force} |
{remove | rm} {<pluginid> | <name>} --save |
{list | ls} |
save |
@@ -324,7 +324,6 @@ cordova {plugin | plugins} [
| |--noregistry | Don't search the registry for plugins.
| |--link | When installing from a local path, creates a symbolic link instead of copying files. The extent to which files are linked varies by platform. Useful for plugin development.
| |--nosave | Do NOT save the `<plugin-spec>` as part of the `plugin` element into `config.xml` or `package.json`.
-| |--browserify | Compile plugin JS at build time using browserify instead of runtime.
| |--force | _Introduced in version 6.1._ Forces copying source files from the plugin even if the same file already exists in the target directory.
| remove `<pluginid>|<name>` [...]| | Remove plugins with the given IDs/name.
| |--nosave | Do NOT remove the specified plugin from config.xml or package.json
@@ -404,7 +403,6 @@ copies plugin files for specified platforms so that the project is ready to buil
```
cordova prepare [<platform> [..]]
- [--browserify]
```
### Options
@@ -412,7 +410,6 @@ cordova prepare [<platform> [..]]
| Option | Description
|------------|------------------
| `<platform> [..]` | Platform name(s) to prepare. If not specified, all platforms are built.
-|--browserify | Compile plugin JS at build time using browserify instead of runtime.
## cordova compile command
@@ -428,7 +425,6 @@ cordova build [<platform> [...]]
[--debug|--release]
[--device|--emulator|--target=<targetName>]
[--buildConfig=<configfile>]
- [--browserify]
[-- <platformOpts>]
```
For detailed documentation see [cordova build command](#cordova-build-command) docs below.
@@ -446,7 +442,6 @@ cordova build [<platform> [...]]
[--debug|--release]
[--device|--emulator]
[--buildConfig=<configfile>]
- [--browserify]
[-- <platformOpts>]
```
@@ -458,7 +453,6 @@ cordova build [<platform> [...]]
| --device | Build it for a device
| --emulator | Build it for an emulator. In particular, the platform architecture might be different for a device Vs emulator.
| --buildConfig=`<configFile>` | Default: build.json in cordova root directory. <br/> Use the specified build configuration file. `build.json` file is used to specify paramaters to customize the app build process esecially related to signing the package.
-| --browserify | Compile plugin JS at build time using browserify instead of runtime
| `<platformOpts>` | To provide platform specific options, you must include them after `--` separator. Review platform guide docs for more details.
### Examples
@@ -489,7 +483,6 @@ cordova run [<platform> [...]]
[--noprepare] [--nobuild]
[--device|--emulator|--target=<targetName>]
[--buildConfig=<configfile>]
- [--browserify]
[-- <platformOpts>]
```
@@ -505,7 +498,6 @@ cordova run [<platform> [...]]
| --emulator | Deploy to an emulator
| --target | Deploy to a specific target emulator/device. Use `--list` to display target options
| --buildConfig=`<configFile>` | Default: build.json in cordova root directory. <br/> Use the specified build configuration file. `build.json` file is used to specify paramaters to customize the app build process esecially related to signing the package.
-| --browserify | Compile plugin JS at build time using browserify instead of runtime
| `<platformOpts>` | To provide platform specific options, you must include them after `--` separator. Review platform guide docs for more details.
### Examples
@@ -660,7 +652,6 @@ cordova config delete <key>
```
cordova config set autosave false
-cordova config set browserify false
```
[Hooks guide]: http://cordova.apache.org/docs/en/latest/guide_appdev_hooks_index.md.html
diff --git a/doc/run.txt b/doc/run.txt
index 8a17307..a6b3c1a 100644
--- a/doc/run.txt
+++ b/doc/run.txt
@@ -29,9 +29,6 @@ Deploys app on specified platform devices / emulators
--buildConfig....................... Use the specified build configuration
instead of default build.json
- --browserify ....................... Compile plugin JS at build time using
- browserify instead of runtime.
-
To provide platform specific options, you must include them after `--`.
Technical details
diff --git a/spec/cli.spec.js b/spec/cli.spec.js
index 6d0e48f..26afc93 100644
--- a/spec/cli.spec.js
+++ b/spec/cli.spec.js
@@ -79,37 +79,37 @@ describe('cordova cli', () => {
it('Test#005 : will call command with all arguments passed through', () => {
return cli(['node', 'cordova', 'build', 'blackberry10', '--', '-k', 'abcd1234']).then(() => {
- expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { argv: ['-k', 'abcd1234'] }, verbose: false, silent: false, browserify: false, fetch: true, nohooks: [ ], searchpath: undefined });
+ expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { argv: ['-k', 'abcd1234'] }, verbose: false, silent: false, fetch: true, nohooks: [ ], searchpath: undefined });
});
}, 60000);
it('Test#006 : will consume the first instance of -d', () => {
return cli(['node', 'cordova', '-d', 'build', 'blackberry10', '--', '-k', 'abcd1234', '-d']).then(() => {
- expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '-d'] }, verbose: true, silent: false, browserify: false, fetch: true, nohooks: [ ], searchpath: undefined });
+ expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '-d'] }, verbose: true, silent: false, fetch: true, nohooks: [ ], searchpath: undefined });
});
});
it('Test#007 : will consume the first instance of --verbose', () => {
return cli(['node', 'cordova', '--verbose', 'build', 'blackberry10', '--', '-k', 'abcd1234', '--verbose']).then(() => {
- expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '--verbose'] }, verbose: true, silent: false, browserify: false, fetch: true, nohooks: [ ], searchpath: undefined });
+ expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '--verbose'] }, verbose: true, silent: false, fetch: true, nohooks: [ ], searchpath: undefined });
});
});
it('Test#008 : will consume the first instance of either --verbose or -d', () => {
return cli(['node', 'cordova', '--verbose', 'build', 'blackberry10', '--', '-k', 'abcd1234', '-d']).then(() => {
- expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '-d'] }, verbose: true, silent: false, browserify: false, fetch: true, nohooks: [ ], searchpath: undefined });
+ expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '-d'] }, verbose: true, silent: false, fetch: true, nohooks: [ ], searchpath: undefined });
});
});
it('Test#009 : will consume the first instance of either --verbose or -d', () => {
return cli(['node', 'cordova', '-d', 'build', 'blackberry10', '--', '-k', 'abcd1234', '--verbose']).then(() => {
- expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '--verbose'] }, verbose: true, silent: false, browserify: false, fetch: true, nohooks: [ ], searchpath: undefined });
+ expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '--verbose'] }, verbose: true, silent: false, fetch: true, nohooks: [ ], searchpath: undefined });
});
});
it('Test#010 : will consume the first instance of --silent', () => {
return cli(['node', 'cordova', '--silent', 'build', 'blackberry10', '--', '-k', 'abcd1234', '--silent']).then(() => {
- expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { silent: true, argv: ['-k', 'abcd1234', '--silent'] }, verbose: false, silent: true, browserify: false, fetch: true, nohooks: [ ], searchpath: undefined });
+ expect(cordova.build).toHaveBeenCalledWith({ platforms: ['blackberry10'], options: { silent: true, argv: ['-k', 'abcd1234', '--silent'] }, verbose: false, silent: true, fetch: true, nohooks: [ ], searchpath: undefined });
});
});
});
diff --git a/src/cli.js b/src/cli.js
index ff8e0c5..59499f6 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -54,7 +54,6 @@ var knownOpts = {
'device': Boolean,
'emulator': Boolean,
'target': String,
- 'browserify': Boolean,
'noprepare': Boolean,
'fetch': Boolean,
'nobuild': Boolean,
@@ -349,7 +348,6 @@ function cli (inputArgs) {
options: [],
verbose: args.verbose || false,
silent: args.silent || false,
- browserify: args.browserify || false,
fetch: true,
nohooks: args.nohooks || [],
searchpath: args.searchpath
@@ -448,10 +446,6 @@ function cli (inputArgs) {
// User explicitly did not pass in save
args.save = conf.get('autosave');
}
- if (args.browserify === undefined) {
- // User explicitly did not pass in browserify
- args.browserify = conf.get('browserify');
- }
if (args.searchpath === undefined) {
// User explicitly did not pass in searchpath
args.searchpath = conf.get('searchpath');
@@ -470,7 +464,6 @@ function cli (inputArgs) {
noregistry: args.noregistry,
nohooks: args.nohooks,
cli_variables: cli_vars,
- browserify: args.browserify || false,
fetch: true,
link: args.link || false,
save: args.save,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org