You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2017/02/14 20:52:00 UTC

[GitHub] trafficserver pull request #1445: Issue #1443 - Fix early or duplicate 404 e...

GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/1445

    Issue #1443 - Fix early or duplicate 404 error handling

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver issue_1443

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1445
    
----
commit 866c00aa085cb1579b48d48f293676bd712006f3
Author: Susan Hinrichs <sh...@ieee.org>
Date:   2017-02-14T20:39:52Z

    Issue #1443 - Fix early or duplicate 404 error handling

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1437/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1550/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    An assert triggers.  A stack trace in the issue description.
    
    https://github.com/apache/trafficserver/issues/1443



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/218/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1445: Issue #1443 - Fix early or duplicate 404 e...

Posted by shinrich <gi...@git.apache.org>.
Github user shinrich closed the pull request at:

    https://github.com/apache/trafficserver/pull/1445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/86/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    What are the symptoms of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/109/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1654/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1544/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:

    https://github.com/apache/trafficserver/pull/1445
  
    I looked at this as well and it definitely looks like it's an artifact of a remap plugin setting the transaction to be an error. You can see that this happens in a switch statement where `t_state.next_action` was `SM_ACTION_REMAP_REQUEST` on entry yet is `SM_ACTION_SEND_ERROR_CACHE_NOOP`. This could only have been updated via `do_remap_request()` and presumably via a remap plugin as `RemapProcessor` doesn't update that member. It also seems reasonable to check if a plugin has error'd out the transaction and give up on further transaction processing at that point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---