You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/09 09:13:00 UTC
[jira] [Commented] (ARTEMIS-2224) Reduce contention on
LivePageCacheImpl
[ https://issues.apache.org/jira/browse/ARTEMIS-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737989#comment-16737989 ]
ASF GitHub Bot commented on ARTEMIS-2224:
-----------------------------------------
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2494
ARTEMIS-2224 Reduce contention on LivePageCacheImpl
It includes:
- **lock-free LivePageCache + tests**:
LivePageCacheImpl has been reimplemented to be
lock-free, multi-producer and multi-consumer
in any of its operations.
- **Avoid unnecessary page cache queries on ack TX**:
PageSubscriptionImpl::ackTx is already performing a counter update
using the message persistent size: the size can be reused on
PagePosition::setPersistentSize, avoiding to query the page cache just
to compute it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis lock-free-paging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2494
----
----
> Reduce contention on LivePageCacheImpl
> --------------------------------------
>
> Key: ARTEMIS-2224
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2224
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
>
> Has been measured that LIvePageCacheImpl operations are a source of contention on producer side while paging.
> This contention decrease the scalability of the broker in an evident way while using topics, because the page cache is been accessed concurrently by several producers to ack transactions while the messages are being appended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)