[GitHub] [hadoop] brumi1024 commented on pull request #5116: YARN-11369. Commons.compress throws an IllegalArgumentException with …

[GitBox <gi...@apache.org>]

brumi1024 commented on PR #5116:
URL: https://github.com/apache/hadoop/pull/5116#issuecomment-1314132283

   @ashutoshcipher do you have a specific way in mind? The behaviour change introduced in 1.21 was that if someone with a large UID creates some files and tries to use the lib with no BigNumberMode set to compress them, it throws an IllegalArgumentException, as opposed to setting the owner id/group to 0. Now to properly reproduce this we would need to create a file with a large enough user ID as owner, call the lib, and [let it copy](https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java#L600) the tar details, but this all seems to me like testing an external lib in a unit test, not to mention that at this stage we're using the local file system, so no owner change is possible to non-existent large UID users. 
   
   What we could do instead is to create a large enough file and test if the compress lib allows that in the header. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org