You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/12 07:50:30 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #37853: [SPARK-40404][DOCS] Fix the wrong description related to `spark.shuffle.service.db.enabled` in the document

LuciferYang commented on code in PR #37853:
URL: https://github.com/apache/spark/pull/37853#discussion_r968087123


##########
docs/spark-standalone.md:
##########
@@ -322,9 +322,9 @@ SPARK_WORKER_OPTS supports the following system properties:
   <td>true</td>
   <td>
     Store External Shuffle service state on local disk so that when the external shuffle service is restarted, it will
-    automatically reload info on current executors.  This only affects standalone mode (yarn always has this behavior
-    enabled).  You should also enable <code>spark.worker.cleanup.enabled</code>, to ensure that the state
-    eventually gets cleaned up.  This config may be removed in the future.
+    automatically reload info on current executors.  This only affects standalone mode.  You should also enable 
+    <code>spark.worker.cleanup.enabled</code>, to ensure that the state eventually gets cleaned up.  
+    This config may be removed in the future.

Review Comment:
   Hmm... does `yarn always has this behavior enabled` mean that YarnShuffleService will always will persist data into Level/RocksDB?
   
   Isn't that right?
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org