You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wave-dev@incubator.apache.org by wisebaldone <gi...@git.apache.org> on 2017/05/08 08:25:55 UTC
[GitHub] incubator-wave pull request #25: Updated builds to use proto3 libraries.
GitHub user wisebaldone opened a pull request:
https://github.com/apache/incubator-wave/pull/25
Updated builds to use proto3 libraries.
Allows us to move forward with using proto3 buffers with new client while keeping old client functional.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wisebaldone/incubator-wave proto3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-wave/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave pull request #25: Updated builds to use proto3 libraries.
Posted by vega113 <gi...@git.apache.org>.
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/25#discussion_r115306212
--- Diff: pst/src/main/proto/google/protobuf/descriptor.proto ---
@@ -37,10 +37,14 @@
// without any other information (e.g. without reading its imports).
+syntax = "proto2";
--- End diff --
looks like we have two "syntax" fields
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave pull request #25: Updated builds to use proto3 libraries.
Posted by vega113 <gi...@git.apache.org>.
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/25#discussion_r115307098
--- Diff: pst/src/main/proto/google/protobuf/descriptor.proto ---
@@ -37,10 +37,14 @@
// without any other information (e.g. without reading its imports).
+syntax = "proto2";
package google.protobuf;
+option go_package = "github.com/golang/protobuf/protoc-gen-go/descriptor;descriptor";
option java_package = "com.google.protobuf";
option java_outer_classname = "DescriptorProtos";
+option csharp_namespace = "Google.Protobuf.Reflection";
--- End diff --
Do we need csharp namespace?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave pull request #25: Updated builds to use proto3 libraries.
Posted by wisebaldone <gi...@git.apache.org>.
Github user wisebaldone commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/25#discussion_r125221637
--- Diff: pst/src/main/proto/google/protobuf/descriptor.proto ---
@@ -37,10 +37,14 @@
// without any other information (e.g. without reading its imports).
+syntax = "proto2";
package google.protobuf;
+option go_package = "github.com/golang/protobuf/protoc-gen-go/descriptor;descriptor";
option java_package = "com.google.protobuf";
option java_outer_classname = "DescriptorProtos";
+option csharp_namespace = "Google.Protobuf.Reflection";
--- End diff --
I do not feel comfortable editing this as its the original file from google which we have listed in the license.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---