[GitHub] [hive] kgyrtkirk commented on a change in pull request #2125: HIVE-24951 : Table created with Uppercase name using CTAS does not produce result for select queries

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2125:
URL: https://github.com/apache/hive/pull/2125#discussion_r645391817



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDefaultTransformer.java
##########
@@ -833,9 +833,9 @@ private Table validateTablePaths(Table table) throws MetaException {
         dbLocation = Path.getPathWithoutSchemeAndAuthority(new Path(db.getLocationUri()));
         Path tablePath = null;
         if (!FileUtils.isSubdirectory(whRootPath.toString(), dbLocation.toString())) {
-          tablePath = new Path(db.getLocationUri(), table.getTableName());
+          tablePath = new Path(db.getLocationUri(), table.getTableName().toLowerCase());
         } else {
-          tablePath = hmsHandler.getWh().getDefaultTablePath(db, table.getTableName(), true);

Review comment:
       why don't we move this `toLowerCase` into the `getDefaultTablePath` function?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org