You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/10 16:40:31 UTC
[GitHub] [doris] morningman opened a new pull request, #10740: [improvement](parquet-reader) Add some profile for parquet reader
morningman opened a new pull request, #10740:
URL: https://github.com/apache/doris/pull/10740
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
1. Copy some profile from VArrowReader to FileArrowReader.
2. Refine the explain message of FileScanNode
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
4. Has unit tests been added: (Yes/No/No Need)
5. Has document been added or modified: (Yes/No/No Need)
6. Does it need to update dependencies: (Yes/No)
7. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #10740: [improvement](parquet-reader) Add some profile for parquet reader
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #10740:
URL: https://github.com/apache/doris/pull/10740#discussion_r917526912
##########
be/src/vec/exec/file_text_scanner.h:
##########
@@ -42,6 +42,9 @@ class FileTextScanner final : public FileScanner {
Status get_next(Block* block, bool* eof) override;
void close() override;
+protected:
+ void _init_profiles(RuntimeProfile* profile) override {}
Review Comment:
I just want to make it more explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #10740: [improvement](parquet-reader) Add some profile for parquet reader
Posted by GitBox <gi...@apache.org>.
wsjz commented on code in PR #10740:
URL: https://github.com/apache/doris/pull/10740#discussion_r917504435
##########
be/src/vec/exec/file_text_scanner.h:
##########
@@ -42,6 +42,9 @@ class FileTextScanner final : public FileScanner {
Status get_next(Block* block, bool* eof) override;
void close() override;
+protected:
+ void _init_profiles(RuntimeProfile* profile) override {}
Review Comment:
the override is useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10740: [improvement](parquet-reader) Add some profile for parquet reader
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10740:
URL: https://github.com/apache/doris/pull/10740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org