You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2017/10/06 05:05:45 UTC
[GitHub] spark pull request #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19442
[SPARK-8515][ML][WIP] Improve ML Attribute API
## What changes were proposed in this pull request?
The current ML attribute API has issues like inefficiency and not easy to use. This work tries to improve this API with main changes:
* Support spark vector-typed attributes.
* Simplify vector-typed attribute serialization.
* Keep minimum APIs to support ML attributes.
## How was this patch tested?
Added tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 SPARK-8515
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19442
----
commit 77d657d8bc8102081e4b0d7b5d42a256e64514d4
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-02T15:03:54Z
Init design of ml attribute.
commit 7837778e7cbbf83851b1a2b5047f4e6a8039f809
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-03T15:03:31Z
revise.
commit 97f6848f0cbb1a76b4434930ce8938da50eaafbe
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-03T15:14:02Z
revise.
commit 2e3a3541fc7a59ac63b2118228de8015c238de40
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-04T05:15:58Z
revise.
commit 0d76eac84f5837aefebc763687fa9c5c7e1aeb4d
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-04T15:07:57Z
revise.
commit 81cca5cccfa2556ff0bba5a73764d3f503040b13
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T04:30:48Z
revise.
commit 4813fe8a4bd19a02b7b6bff138f04e7e50f7cdd7
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T06:15:53Z
revise.
commit 7951f59027418962ad95465e439bff41876ecfa8
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T07:51:50Z
revise.
commit a381af3edf52132086af64360789cb3a7d20d61e
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T09:00:02Z
Add builder and test.
commit f25c89dbded0eb9dce25d8da63a1a1aa49ad459f
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T15:10:11Z
revise test.
commit 7e237f38088f2375f40f9a4c97aee2e6acd54328
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-06T02:46:07Z
Add new test.
commit 77ced957e7be2169ac0c59c76f60ab9d4fcac3ef
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-06T03:57:12Z
Add more tests.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19442
Before the discussion of attribute API is finalized, I think the review won't be started. Close this for now and maybe re-open in the future.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82511/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82503/testReport)** for PR 19442 at commit [`de0aa76`](https://github.com/apache/spark/commit/de0aa76199141255258d9d5b12a0d31b1758c6f1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82760/testReport)** for PR 19442 at commit [`51440b4`](https://github.com/apache/spark/commit/51440b4eeefece4f899a21ef1a0a63399a9f95ac).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82496/testReport)** for PR 19442 at commit [`3d27852`](https://github.com/apache/spark/commit/3d2785204e40c701b7b7df36144592ab8c93bc74).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/19442
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82759/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82511/testReport)** for PR 19442 at commit [`d828cf3`](https://github.com/apache/spark/commit/d828cf3d3b13a2b2b1990bdff9593b49e53f6cf9).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82500/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82496/testReport)** for PR 19442 at commit [`3d27852`](https://github.com/apache/spark/commit/3d2785204e40c701b7b7df36144592ab8c93bc74).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19442
@VDuda Thanks for asking. This is a big change. I hope this PR can resolve SPARK-8515.
Most APIs are ready. I'm working on the compatibility with current attribute APIs. When it is ready, I'll re-open this for review.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82497/testReport)** for PR 19442 at commit [`de0aa76`](https://github.com/apache/spark/commit/de0aa76199141255258d9d5b12a0d31b1758c6f1).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82500/testReport)** for PR 19442 at commit [`de0aa76`](https://github.com/apache/spark/commit/de0aa76199141255258d9d5b12a0d31b1758c6f1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82495/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82760/testReport)** for PR 19442 at commit [`51440b4`](https://github.com/apache/spark/commit/51440b4eeefece4f899a21ef1a0a63399a9f95ac).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82503/testReport)** for PR 19442 at commit [`de0aa76`](https://github.com/apache/spark/commit/de0aa76199141255258d9d5b12a0d31b1758c6f1).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82497/testReport)** for PR 19442 at commit [`de0aa76`](https://github.com/apache/spark/commit/de0aa76199141255258d9d5b12a0d31b1758c6f1).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82495/testReport)** for PR 19442 at commit [`77ced95`](https://github.com/apache/spark/commit/77ced957e7be2169ac0c59c76f60ab9d4fcac3ef).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82759/testReport)** for PR 19442 at commit [`2b94dd5`](https://github.com/apache/spark/commit/2b94dd5c192b1d9302e24c0392fc9a5aaaedb596).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82500/testReport)** for PR 19442 at commit [`de0aa76`](https://github.com/apache/spark/commit/de0aa76199141255258d9d5b12a0d31b1758c6f1).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
GitHub user viirya reopened a pull request:
https://github.com/apache/spark/pull/19442
[SPARK-8515][ML][WIP] Improve ML Attribute API
## What changes were proposed in this pull request?
The current ML attribute API has issues like inefficiency and not easy to use. This work tries to improve this API with main changes:
* Support spark vector-typed attributes.
* Simplify vector-typed attribute serialization.
* Keep minimum APIs to support ML attributes.
** THIS WORK is not ready and is working in progress.
## How was this patch tested?
Added tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 SPARK-8515
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19442
----
commit 77d657d8bc8102081e4b0d7b5d42a256e64514d4
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-02T15:03:54Z
Init design of ml attribute.
commit 7837778e7cbbf83851b1a2b5047f4e6a8039f809
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-03T15:03:31Z
revise.
commit 97f6848f0cbb1a76b4434930ce8938da50eaafbe
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-03T15:14:02Z
revise.
commit 2e3a3541fc7a59ac63b2118228de8015c238de40
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-04T05:15:58Z
revise.
commit 0d76eac84f5837aefebc763687fa9c5c7e1aeb4d
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-04T15:07:57Z
revise.
commit 81cca5cccfa2556ff0bba5a73764d3f503040b13
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T04:30:48Z
revise.
commit 4813fe8a4bd19a02b7b6bff138f04e7e50f7cdd7
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T06:15:53Z
revise.
commit 7951f59027418962ad95465e439bff41876ecfa8
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T07:51:50Z
revise.
commit a381af3edf52132086af64360789cb3a7d20d61e
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T09:00:02Z
Add builder and test.
commit f25c89dbded0eb9dce25d8da63a1a1aa49ad459f
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-05T15:10:11Z
revise test.
commit 7e237f38088f2375f40f9a4c97aee2e6acd54328
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-06T02:46:07Z
Add new test.
commit 77ced957e7be2169ac0c59c76f60ab9d4fcac3ef
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-06T03:57:12Z
Add more tests.
commit de0aa76199141255258d9d5b12a0d31b1758c6f1
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-06T06:17:29Z
revise.
commit d828cf3d3b13a2b2b1990bdff9593b49e53f6cf9
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-06T13:55:41Z
Add java-friendly APIs for attribute types.
commit 5844fbaef5d5825eafadb7c53196fb2132937e4e
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-09T03:24:26Z
Revise APIs.
commit da0fcef7d3370ebca97d200f01e9f2814a9ed755
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-09T03:26:15Z
revise.
commit 66be26cd7f25614137cfb9722f859f36d9f80c0c
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-09T03:47:43Z
Add default constructors to attribute types.
commit ce80ed5b693745fa4a650e508c6cd9e24350c52e
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-10T12:52:22Z
Use Array instead of Seq in APIs.
commit 2b94dd5c192b1d9302e24c0392fc9a5aaaedb596
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-10-14T00:21:04Z
Add more compatibility tests.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by VDuda <gi...@git.apache.org>.
Github user VDuda commented on the issue:
https://github.com/apache/spark/pull/19442
Following the issue, does this mean that this PR resolves https://issues.apache.org/jira/browse/SPARK-8515 ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/19442
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82496/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82511/testReport)** for PR 19442 at commit [`d828cf3`](https://github.com/apache/spark/commit/d828cf3d3b13a2b2b1990bdff9593b49e53f6cf9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82503/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82760/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19442
retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82497/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19442
@MLnick Can you take a look and give me some suggestion? Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82759/testReport)** for PR 19442 at commit [`2b94dd5`](https://github.com/apache/spark/commit/2b94dd5c192b1d9302e24c0392fc9a5aaaedb596).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82495/testReport)** for PR 19442 at commit [`77ced95`](https://github.com/apache/spark/commit/77ced957e7be2169ac0c59c76f60ab9d4fcac3ef).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19442
retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19442
Will re-open when this is ready.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org