You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/03/10 01:11:05 UTC
[GitHub] [incubator-eventmesh] fengyongshe opened a new pull request #807: [ISSUE #806] code optimization and delete invalid code in eventmesh-e…
fengyongshe opened a new pull request #807:
URL: https://github.com/apache/incubator-eventmesh/pull/807
Fixes ISSUE #806.
### Motivation
code optimization and delete invalid code in eventmesh-examples module
### Modifications
*Use ExampleConstants to hold constants in examples
*Delete invalid code in AsyncSubscribe
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #807: [ISSUE #806] code optimization and delete invalid code in eventmesh-e…
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #807:
URL: https://github.com/apache/incubator-eventmesh/pull/807#discussion_r823252078
##########
File path: eventmesh-examples/src/main/java/org/apache/eventmesh/grpc/sub/app/service/SubService.java
##########
@@ -115,8 +115,8 @@ public void cleanup() {
* Count the message already consumed
*/
public void consumeMessage(String msg) {
- logger.info("consume message {}", msg);
+ logger.info("consume message: {}", msg);
countDownLatch.countDown();
- logger.info("remaining number of messages to be consumed {}", countDownLatch.getCount());
+ logger.info("remaining number of messages to be consumed : {}", countDownLatch.getCount());
Review comment:
For code style consistency, you can delete this space.
```suggestion
logger.info("remaining number of messages to be consumed: {}", countDownLatch.getCount());
```
##########
File path: eventmesh-examples/src/main/java/org/apache/eventmesh/http/demo/pub/eventmeshmessage/SyncRequestInstance.java
##########
@@ -71,7 +73,7 @@ public static void main(String[] args) throws Exception {
EventMeshMessage rsp = eventMeshHttpProducer.request(eventMeshMessage, 10000);
if (logger.isDebugEnabled()) {
- logger.debug("sendmsg : {}, return : {}, cost:{}ms", eventMeshMessage.getContent(), rsp.getContent(),
+ logger.debug("sendmsg : {}, return : {}, cost:{} ms", eventMeshMessage.getContent(), rsp.getContent(),
Review comment:
```suggestion
logger.debug("sendmsg: {}, return: {}, cost:{} ms", eventMeshMessage.getContent(), rsp.getContent(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] fengyongshe commented on a change in pull request #807: [ISSUE #806] code optimization and delete invalid code in eventmesh-e…
Posted by GitBox <gi...@apache.org>.
fengyongshe commented on a change in pull request #807:
URL: https://github.com/apache/incubator-eventmesh/pull/807#discussion_r823276740
##########
File path: eventmesh-examples/src/main/java/org/apache/eventmesh/http/demo/pub/eventmeshmessage/SyncRequestInstance.java
##########
@@ -71,7 +73,7 @@ public static void main(String[] args) throws Exception {
EventMeshMessage rsp = eventMeshHttpProducer.request(eventMeshMessage, 10000);
if (logger.isDebugEnabled()) {
- logger.debug("sendmsg : {}, return : {}, cost:{}ms", eventMeshMessage.getContent(), rsp.getContent(),
+ logger.debug("sendmsg : {}, return : {}, cost:{} ms", eventMeshMessage.getContent(), rsp.getContent(),
Review comment:
ok, I completed the codestyle style consistency in second pr. please review it. @ruanwenjun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #807: [ISSUE #806] code optimization and delete invalid code in eventmesh-e…
Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #807:
URL: https://github.com/apache/incubator-eventmesh/pull/807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] fengyongshe commented on a change in pull request #807: [ISSUE #806] code optimization and delete invalid code in eventmesh-e…
Posted by GitBox <gi...@apache.org>.
fengyongshe commented on a change in pull request #807:
URL: https://github.com/apache/incubator-eventmesh/pull/807#discussion_r823276740
##########
File path: eventmesh-examples/src/main/java/org/apache/eventmesh/http/demo/pub/eventmeshmessage/SyncRequestInstance.java
##########
@@ -71,7 +73,7 @@ public static void main(String[] args) throws Exception {
EventMeshMessage rsp = eventMeshHttpProducer.request(eventMeshMessage, 10000);
if (logger.isDebugEnabled()) {
- logger.debug("sendmsg : {}, return : {}, cost:{}ms", eventMeshMessage.getContent(), rsp.getContent(),
+ logger.debug("sendmsg : {}, return : {}, cost:{} ms", eventMeshMessage.getContent(), rsp.getContent(),
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org