[GitHub] [geode-examples] rhoughton-pivot opened pull request #87: Allow custom geode integration

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

Building examples has required a published Geode tgz and jars. Use
Gradle's includeBuild feature to allow mapping to a custom Geode clone
for integration and API testing. Invoke with:
./gradlew -Dcomposite -PgeodeCompositeDirectory=../geode build

Once more, with feeling. Re-submitting this PR against `develop` instead of `master`

[ Full content available at: https://github.com/apache/geode-examples/pull/87 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-examples] rhoughton-pivot commented on issue #87: Allow custom geode integration

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

@upthewaterspout Because of the name mapping between the `geode-assembly` project and its artifact name `apache-geode` the default behavior of  --include-build does not work for the Geode project. The `substitution` lines in `settings.gradle` are to teach Gradle how to map our project names. In addition, the tgz output of `geode-assembly` has a classification component that needs to be provided in order to download and unpack the archive from within Gradle as a normal dependency, as opposed to a `JavaExec` that downloads the file.

We can pair up and try it with the default `--include-build` flags to see if I'm mistaken though. I'm always happy to remove complicated, obscure build logic.

[ Full content available at: https://github.com/apache/geode-examples/pull/87 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-examples] upthewaterspout commented on issue #87: Allow custom geode integration

["upthewaterspout (GitHub)" <gi...@apache.org>]

gradle has a built in --include-build option that looks like it does this same thing without all of the custom logic in the build file. Is there a reason we're not using that?

[ Full content available at: https://github.com/apache/geode-examples/pull/87 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org