[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25425: [SPARK-28497][FOLLOWUP][SQL] Allow cast NullType to StringType

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #25425: [SPARK-28497][FOLLOWUP][SQL] Allow cast NullType to StringType
URL: https://github.com/apache/spark/pull/25425#discussion_r313196333
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ##########
 @@ -134,6 +134,7 @@ object Cast {
     case (DateType, TimestampType) => true
     case (_: AtomicType, StringType) => true
     case (_: CalendarIntervalType, StringType) => true
+    case (NullType, StringType) => true
 
 Review comment:
   So this is a logical partial recover of the previous code `case (_, StringType) => true` before #25242, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org