You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/26 16:06:43 UTC
[GitHub] [maven] slachiewicz opened a new pull request #320: [MNG-6856]
Remove dependency to Powermock
slachiewicz opened a new pull request #320: [MNG-6856] Remove dependency to Powermock
URL: https://github.com/apache/maven/pull/320
https://jira.apache.org/jira/browse/MNG-6856
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6856/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #320:
[MNG-6856] Remove dependency to Powermock
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #320: [MNG-6856] Remove dependency to Powermock
URL: https://github.com/apache/maven/pull/320#discussion_r371011125
##########
File path: maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
##########
@@ -33,15 +33,18 @@
import java.util.concurrent.Future;
import java.util.concurrent.FutureTask;
+import static org.apache.commons.lang3.reflect.FieldUtils.readField;
Review comment:
That's a problem because we want to remove Commons Lang from Core.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] slachiewicz commented on a change in pull request #320:
[MNG-6856] Remove dependency to Powermock
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #320: [MNG-6856] Remove dependency to Powermock
URL: https://github.com/apache/maven/pull/320#discussion_r371017374
##########
File path: maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
##########
@@ -33,15 +33,18 @@
import java.util.concurrent.Future;
import java.util.concurrent.FutureTask;
+import static org.apache.commons.lang3.reflect.FieldUtils.readField;
Review comment:
Yes, I forgot about that, now I removed that class usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services