You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@storm.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2018/04/02 14:30:00 UTC

[jira] [Resolved] (STORM-2649) Update config validation check to give better information

     [ https://issues.apache.org/jira/browse/STORM-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans resolved STORM-2649.
----------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Thanks [~ghajos],

 

I merged this into master.  If you want to pull it back into other release lines feel free to open up other pull requests.

> Update config validation check to give better information
> ---------------------------------------------------------
>
>                 Key: STORM-2649
>                 URL: https://issues.apache.org/jira/browse/STORM-2649
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-client
>    Affects Versions: 2.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Gergely Hajós
>            Priority: Major
>              Labels: newbie, pull-request-available
>             Fix For: 2.0.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> As part of submitting a topology we need to serialize the config as JSON.  The check right now is rather bad. it just calls Utils.isValidConf and throws some generic Exception about problems.
> https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/utils/Utils.java#L978-L980
> It would be much better to have a new function/method that would check if they are equal and if not it would walk through them looking for which configs are different when it finds one it includes which configs and how they are different in the exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)