[GitHub] [nifi] tpalfy opened a new pull request, #7809: NIFI-12131 Fix potential NPE when FlowAnalyzer and RuleViolationsManager are not set.

["tpalfy (via GitHub)" <gi...@apache.org>]

tpalfy opened a new pull request, #7809:
URL: https://github.com/apache/nifi/pull/7809

   Fix NPE: Revamped RuleViolationsManager and FlowAnalyzer handling to make sure no issue occurs when these are not set. Fix ResourceNotFoundException: When determining the subject permissions for a rule violation the type of the subject is now known, so we try to lookup all possible types. Non-matching tpyes throw a ResourceNotFoundException exception though. Going to ignore those.
   
   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-12131](https://issues.apache.org/jira/browse/NIFI-12131)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-12131 Fix potential NPE when FlowAnalyzer and RuleViolationsManager are not set. [nifi]

["tpalfy (via GitHub)" <gi...@apache.org>]

tpalfy commented on PR #7809:
URL: https://github.com/apache/nifi/pull/7809#issuecomment-1742847325

   @exceptionfactory I'm not entirely familiar with all possible NiFi runtimes but in general only the regular NiFi would have FlowAnalyzer and RuleViolationsManager set. At least that was the intent.
   All other runtimes (MiNiFi, Stateless NiFi) would have these as null.
   
   I think Optional servers exactly this kind of purpose.
   Setting any kind of dummy implementation would require us to identify all the injection and/or explicit instantiation points and we would need to maintain the dummy classes. It would lead to a more convoluted design and implementation in my opinion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-12131 Fix potential NPE when FlowAnalyzer and RuleViolationsManager are not set. [nifi]

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory closed pull request #7809: NIFI-12131 Fix potential NPE when FlowAnalyzer and RuleViolationsManager are not set.
URL: https://github.com/apache/nifi/pull/7809


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org