You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/05/28 09:27:22 UTC
Review Request: Updated account and domain id for nic secondary ips for
shared networks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11458/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
Description
-------
Updated account and domain id for nic secondary ips for shared networks.
Fixed by getting accoundId and domainId from the caller instead of network
This addresses bug CLOUDSTACK-2609.
Diffs
-----
server/src/com/cloud/network/NetworkServiceImpl.java f880bcc
Diff: https://reviews.apache.org/r/11458/diff/
Testing
-------
Tested on isolated and shared networks.
Thanks,
Jayapal Reddy
Re: Review Request: Updated account and domain id for nic secondary ips for
shared networks
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11458/#review21702
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On June 11, 2013, 6:24 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11458/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 6:24 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated account and domain id for nic secondary ips for shared networks.
> Fixed by getting accoundId and domainId from the caller instead of network
>
>
> This addresses bug CLOUDSTACK-2609.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java d5a59d6
>
> Diff: https://reviews.apache.org/r/11458/diff/
>
>
> Testing
> -------
>
> Tested on isolated and shared networks.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Updated account and domain id for nic secondary ips for
shared networks
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11458/
-----------------------------------------------------------
(Updated June 11, 2013, 6:24 a.m.)
Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
Changes
-------
Updated to ipOwner
Description
-------
Updated account and domain id for nic secondary ips for shared networks.
Fixed by getting accoundId and domainId from the caller instead of network
This addresses bug CLOUDSTACK-2609.
Diffs (updated)
-----
server/src/com/cloud/network/NetworkServiceImpl.java d5a59d6
Diff: https://reviews.apache.org/r/11458/diff/
Testing
-------
Tested on isolated and shared networks.
Thanks,
Jayapal Reddy
Re: Review Request: Updated account and domain id for nic secondary ips for
shared networks
Posted by Jayapal Reddy <ja...@citrix.com>.
> On June 4, 2013, 5:47 a.m., Murali Reddy wrote:
> > Should set the owner to be entity owner passed as ipowner instead of caller.
Updated to ipOwner
- Jayapal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11458/#review21409
-----------------------------------------------------------
On May 28, 2013, 7:27 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11458/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 7:27 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated account and domain id for nic secondary ips for shared networks.
> Fixed by getting accoundId and domainId from the caller instead of network
>
>
> This addresses bug CLOUDSTACK-2609.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java f880bcc
>
> Diff: https://reviews.apache.org/r/11458/diff/
>
>
> Testing
> -------
>
> Tested on isolated and shared networks.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Updated account and domain id for nic secondary ips for
shared networks
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11458/#review21409
-----------------------------------------------------------
Should set the owner to be entity owner passed as ipowner instead of caller.
- Murali Reddy
On May 28, 2013, 7:27 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11458/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 7:27 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated account and domain id for nic secondary ips for shared networks.
> Fixed by getting accoundId and domainId from the caller instead of network
>
>
> This addresses bug CLOUDSTACK-2609.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java f880bcc
>
> Diff: https://reviews.apache.org/r/11458/diff/
>
>
> Testing
> -------
>
> Tested on isolated and shared networks.
>
>
> Thanks,
>
> Jayapal Reddy
>
>