[GitHub] [airflow] alexbegg commented on pull request #8777: Add Production Helm chart support

[GitBox <gi...@apache.org>]

alexbegg commented on pull request #8777:
URL: https://github.com/apache/airflow/pull/8777#issuecomment-639662552


   > > @thesuperzapper In my opinion both charts need to be improved but we should go with the Astronomer chart. I mean, the work you've done with stable/chart of airflow is amazing but there are many issues when we want to use it with the Kubernetes executor. At this moment, I'm fixing issues related to Git-Sync and before it was related to the repo.
   > > The Astronomer chart is used in production by many companies and big companies, thousands of tasks are running every day and so it has been well experienced and tested. The sooner we merge this PR the faster we could move on and start making improvements based on what you've done :)
   > 
   > I'd have to disagree about your point about the issues related to using the KubernetesExecutor with the `stable/airflow` chart. Sure there can be some improvements, but it's by no means a deal breaker to get going with. There was even a [recent update](https://github.com/helm/charts/blob/master/stable/airflow/UPGRADE.md#v70x--v710) to the chart geared towards making it easier to setup the KubernetesExecutor.
   > 
   > I do recall having some issues with the Git-sync component, but did ultimately get it working. The actual specifics I don't remember at this point, because I am going the direction of baking the DAGs into my Airflow image since it fits perfectly with the workflows we already have elsewhere. So it may take some messing around to get the pieces to line up, but it does work. As opposed to the Astronomer chart which doesn't already have this functionality available.
   > 
   > So in terms of doing something that will merge the PR and lead to making improvements faster, my opinion is that the best path would be to give `stable/airflow` the new home that it needs and go from there.
   
   I just got git-sync working with stable/airflow as of yesterday, even with an SSH key for a private repo, so I don't see any problems. I think there was some improvements made to it so maybe the issue you had was fixed. I am preparing to migrate a production VM deployment to stable/airflow chart deployment in Azure's AKS


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org