You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2018/07/28 03:55:12 UTC

[GitHub] spark pull request #21905: [SPARK-24956][Build][test-maven] Upgrade maven ve...

GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/21905

    [SPARK-24956][Build][test-maven] Upgrade maven version to 3.5.4

    ## What changes were proposed in this pull request?
    
    This PR updates maven version from 3.3.9 to 3.5.4. The current build process uses mvn 3.3.9 that was release on 2015, which looks pretty old.
    We met [an issue](https://issues.apache.org/jira/browse/SPARK-24895) to need the maven 3.5.2 or later.
    
    The release note of the 3.5.4 is [here](https://maven.apache.org/docs/3.5.4/release-notes.html).
    
    From [the release note of the 3.5.0](https://maven.apache.org/docs/3.5.0/release-notes.html), the followings are new features:
    1. ANSI color logging for improved output visibility
    1. add support for module name != artifactId in every calculated URLs (project, SCM, site): special project.directory property
    1. create a slf4j-simple provider extension that supports level color rendering
    1. ModelResolver interface enhancement: addition of resolveModel(Dependency) supporting version ranges
    
    ## How was this patch tested?
    
    Existing tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-24956

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21905.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21905
    
----
commit a8a545cb6b4187dcf88e06eb67b14f743fb5ad55
Author: Kazuaki Ishizaki <is...@...>
Date:   2018-07-28T03:49:10Z

    update maven.version to 3.5.4

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1442/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    **[Test build #93718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93718/testReport)** for PR 21905 at commit [`a8a545c`](https://github.com/apache/spark/commit/a8a545cb6b4187dcf88e06eb67b14f743fb5ad55).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by kiszk <gi...@git.apache.org>.

Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    cc @srowen  @HyukjinKwon 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    **[Test build #93711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93711/testReport)** for PR 21905 at commit [`a8a545c`](https://github.com/apache/spark/commit/a8a545cb6b4187dcf88e06eb67b14f743fb5ad55).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1436/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    **[Test build #93718 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93718/testReport)** for PR 21905 at commit [`a8a545c`](https://github.com/apache/spark/commit/a8a545cb6b4187dcf88e06eb67b14f743fb5ad55).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    Oh darnit, as soon as I merge this (which is fine) it triggers me to think -- this should also have updated the version of Maven that the build script downloads for you. I'll do that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/21905
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org