[GitHub] eric-haibin-lin commented on a change in pull request #7251: update sparse ndarray api

[gi...@git.apache.org]

eric-haibin-lin commented on a change in pull request #7251: update sparse ndarray api 
URL: https://github.com/apache/incubator-mxnet/pull/7251#discussion_r130270026
 
 

 ##########
 File path: python/mxnet/ndarray/__init__.py
 ##########
 @@ -3,10 +3,10 @@
 from . import _internal
 from . import op
 from .op import CachedOp, invoke
-from .ndarray import NDArray, array, concatenate, _DTYPE_NP_TO_MX, _DTYPE_MX_TO_NP
-from .ndarray import empty, ones, add, arange, divide, equal, full, greater, greater_equal, imdecode
+from .ndarray import NDArray, concatenate, _DTYPE_NP_TO_MX, _DTYPE_MX_TO_NP
+from .ndarray import ones, add, arange, divide, equal, full, greater, greater_equal, imdecode
 from .ndarray import lesser, lesser_equal, maximum, minimum, moveaxis, multiply, negative, not_equal
 from .ndarray import onehot_encode, power, subtract, true_divide, waitall, _new_empty_handle
-from .ndarray_utils import load, save, zeros
-from .sparse_ndarray import _ndarray_cls
-from .sparse_ndarray import csr, row_sparse, SparseNDArray, todense, RowSparseNDArray, CSRNDArray
+from .ndarray_utils import load, save, zeros, empty, array
+from .sparse_ndarray import _ndarray_cls, todense
+from .sparse_ndarray import csr, row_sparse, BaseSparseNDArray, RowSparseNDArray, CSRNDArray
 
 Review comment:
   `NDArrayBase` is not exposed to users. Since we also have `BaseModule` and `Module`, I thought `BaseSparseNDArray` could indicate the same thing. @nikrao what name do you think is better to use as the base class for CSRNDArray and RowSparseNDArray?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services