You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ds...@apache.org on 2017/10/30 19:15:35 UTC
[geode] branch feature/GEODE-3781 updated: minor cleanup
This is an automated email from the ASF dual-hosted git repository.
dschneider pushed a commit to branch feature/GEODE-3781
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/feature/GEODE-3781 by this push:
new 83566d4 minor cleanup
83566d4 is described below
commit 83566d41d5cf83238ad4349d36ccbff0f917a55f
Author: Darrel Schneider <ds...@pivotal.io>
AuthorDate: Mon Oct 30 12:15:19 2017 -0700
minor cleanup
---
.../src/main/java/org/apache/geode/connectors/jdbc/JDBCManager.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCManager.java b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCManager.java
index 42224f9..69d0cdb 100644
--- a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCManager.java
+++ b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCManager.java
@@ -67,6 +67,7 @@ public class JDBCManager {
List<ColumnValue> columnList = getColumnToValueList(tableName, key, value, operation);
int updateCount = executeWrite(columnList, tableName, operation, pdxTypeId, false);
if (operation.isDestroy()) {
+ // TODO: should we check updateCount here?
return;
}
if (updateCount <= 0) {
@@ -129,6 +130,7 @@ public class JDBCManager {
private String getDestroyQueryString(String tableName, List<ColumnValue> columnList) {
assert columnList.size() == 1;
ColumnValue keyCV = columnList.get(0);
+ assert keyCV.isKey();
StringBuilder query =
new StringBuilder("DELETE FROM " + tableName + " WHERE " + keyCV.getColumnName() + " = ?");
return query.toString();
@@ -288,7 +290,7 @@ public class JDBCManager {
}
private boolean isFieldExcluded(String fieldName) {
- // TODO Auto-generated method stub
+ // TODO check configuration
return false;
}
--
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].