You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/11/11 08:37:48 UTC
[GitHub] [incubator-streampark] wangsizhu0504 opened a new pull request, #2005: [Fix] username len and fix role error
wangsizhu0504 opened a new pull request, #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
Modified the user name length limit error issue when creating a user
add project:delete role and app:lauch role
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2005: [Fix] username len and fix role error
Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005#discussion_r1020090496
##########
streampark-console/streampark-console-webapp/src/locales/lang/zh-CN/system/user.ts:
##########
@@ -39,7 +39,7 @@ export default {
lastLoginTime: '最近登录时间',
password: '密码',
passwordRequire: '密码为必填项',
- passwordHelp: '密码长度不能少于 8 个字符',
+ passwordHelp: '密码长度不能少于 20 个字符',
Review Comment:
"不能大于20个字符"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wangsizhu0504 commented on a diff in pull request #2005: [Fix] username len and fix role error
Posted by GitBox <gi...@apache.org>.
wangsizhu0504 commented on code in PR #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005#discussion_r1020095878
##########
streampark-console/streampark-console-webapp/src/locales/lang/zh-CN/system/user.ts:
##########
@@ -39,7 +39,7 @@ export default {
lastLoginTime: '最近登录时间',
password: '密码',
passwordRequire: '密码为必填项',
- passwordHelp: '密码长度不能少于 8 个字符',
+ passwordHelp: '密码长度不能少于 20 个字符',
Review Comment:
Sorry, thanks for the reminder. There is a mistake here. The password length cannot be less than 8 characters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wangsizhu0504 commented on pull request #2005: [Fix] username len and fix role error
Posted by GitBox <gi...@apache.org>.
wangsizhu0504 commented on PR #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005#issuecomment-1311701231
> Hi @wangsizhu0504 , why do you add the `pnpm-lock.yaml`?
When there is a lock file, the front-end installation dependency will be downloaded according to the information recorded in the lock file, which records the version of the dependency installation, which can sometimes avoid some unnecessary problems. At the same time, you can also speed up your dependency on downloads. If there is no lock.yam, npm will download the latest version of the dependency, but sometimes the latest version of the dependency may affect the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wangsizhu0504 commented on pull request #2005: [Fix] username len and fix role error
Posted by GitBox <gi...@apache.org>.
wangsizhu0504 commented on PR #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005#issuecomment-1311772821
> > > Hi @wangsizhu0504 , why do you add the `pnpm-lock.yaml`?
> >
> >
> > When there is a lock file, the front-end installation dependency will be downloaded according to the information recorded in the lock file, which records the version of the dependency installation, which can sometimes avoid some unnecessary problems. At the same time, you can also speed up your dependency on downloads. If there is no lock.yam, npm will download the latest version of the dependency, but sometimes the latest version of the dependency may affect the project.
>
> We can refer other apache projects how to solve this problem, such as Apache Flink
ok! Well, it was thoughtless before. The current solution is to clear the lock file (the official source of NPM in China is slow to download), and add the method of setting the image source in readme. Chinese developers can speed up dependent downloads according to this method when using this project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2005: [Fix] username len and fix role error
Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2005: [Fix] username len and fix role error
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005#issuecomment-1311741168
> > Hi @wangsizhu0504 , why do you add the `pnpm-lock.yaml`?
>
> When there is a lock file, the front-end installation dependency will be downloaded according to the information recorded in the lock file, which records the version of the dependency installation, which can sometimes avoid some unnecessary problems. At the same time, you can also speed up your dependency on downloads. If there is no lock.yam, npm will download the latest version of the dependency, but sometimes the latest version of the dependency may affect the project.
We can refer other apache projects how to solve this problem, such as Apache Flink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2005: [Fix] username len and fix role error
Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005#discussion_r1020275575
##########
streampark-console/streampark-console-webapp/README.md:
##########
@@ -49,6 +49,19 @@ Open the project in Gitpod (free online dev environment for GitHub) and start co
Console is written using Javascript. If you don't have a Node.js development environment, please [set it up](https://nodejs.org/en/download/). The minimum version required is 14.0.
+- Set the npm mirror source If you are experiencing a slow download of dependencies, you need to configure the npm mirror source by finding .npmrc in the user folder and writing the following
+
+```bash
+strict-peer-dependencies=false
+save-workspace-protocol = rolling
+registry = 'http://registry.npm.taobao.org'
+sass_binary_site='http://npm.taobao.org/mirrors/node-sass/'
Review Comment:
hi sizhu:
`http://registry.npm.taobao.org` Chinese developers access npm faster , so we can declare in README.zh-CN.md not README.md(developers from other countries don't know it. I recommend to set it as the official mirror of npm)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wangsizhu0504 commented on a diff in pull request #2005: [Fix] username len and fix role error
Posted by GitBox <gi...@apache.org>.
wangsizhu0504 commented on code in PR #2005:
URL: https://github.com/apache/incubator-streampark/pull/2005#discussion_r1020277392
##########
streampark-console/streampark-console-webapp/README.md:
##########
@@ -49,6 +49,19 @@ Open the project in Gitpod (free online dev environment for GitHub) and start co
Console is written using Javascript. If you don't have a Node.js development environment, please [set it up](https://nodejs.org/en/download/). The minimum version required is 14.0.
+- Set the npm mirror source If you are experiencing a slow download of dependencies, you need to configure the npm mirror source by finding .npmrc in the user folder and writing the following
+
+```bash
+strict-peer-dependencies=false
+save-workspace-protocol = rolling
+registry = 'http://registry.npm.taobao.org'
+sass_binary_site='http://npm.taobao.org/mirrors/node-sass/'
Review Comment:
ok！Thanks for reminding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org