You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/04 00:21:57 UTC

[GitHub] [airflow] zzlbuaa opened a new pull request #5531: [AIRFLOW-4894]Add hook and operator for GCP DLP

zzlbuaa opened a new pull request #5531: [AIRFLOW-4894]Add hook and operator for GCP DLP
URL: https://github.com/apache/airflow/pull/5531
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-4894) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Add a hook and operator for GCP Data Loss Prevention(DLP).
   
   DLP API allows users to inspect or redact sensitive data in text contents or GCP storage locations.
   
   The hook includes the following APIs that addresses most use cases in sensitive data inspection and redaction:
    - inspect/deidentify/reidentify for content items
    - create/delete/get/list/patch for inspectTemplates and storedInfoTypes
    - create/list/get/delete/cancel for dlpJobs
   
   Since the dlp job are long-running and created asynchronously, the operator creates a dlp job(for storage inspection or risk analysis), keeps polling its status and waits for it to be done or canceled/deleted.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   See tests/contrib/hooks/test_gcp_data_loss_prevention_hook.py
   and tests/contrib/operators/test_gcp_run_dlp_job.py
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services