You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/12/13 02:20:06 UTC
[kudu-CR] [itests] a couple of new test utility functions
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8826
Change subject: [itests] a couple of new test utility functions
......................................................................
[itests] a couple of new test utility functions
Moved GetServers[With,Without]Replica() utility test functions from
RaftConsensusNonVoterITest into the TabletServerIntegrationTestBase
class to start using them from other tests as well.
This changelist does not have any functional modifications.
Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
---
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
3 files changed, 58 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/8826/1
--
To view, visit http://gerrit.cloudera.org:8080/8826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
Gerrit-Change-Number: 8826
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [itests] a couple of new test utility functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8826
to look at the new patch set (#2).
Change subject: [itests] a couple of new test utility functions
......................................................................
[itests] a couple of new test utility functions
Moved GetServers[With,Without]Replica() utility test functions from
RaftConsensusNonVoterITest into the TabletServerIntegrationTestBase
class to start using them from other tests as well.
This changelist does not have any functional modifications.
Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
---
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
3 files changed, 60 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/8826/2
--
To view, visit http://gerrit.cloudera.org:8080/8826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
Gerrit-Change-Number: 8826
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [itests] a couple of new test utility functions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8826 )
Change subject: [itests] a couple of new test utility functions
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
Gerrit-Change-Number: 8826
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 14 Dec 2017 18:26:33 +0000
Gerrit-HasComments: No
[kudu-CR] [itests] a couple of new test utility functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8826
to look at the new patch set (#3).
Change subject: [itests] a couple of new test utility functions
......................................................................
[itests] a couple of new test utility functions
Moved GetServers[With,Without]Replica() utility test functions from
RaftConsensusNonVoterITest into the TabletServerIntegrationTestBase
class to start using them from other tests as well.
This changelist does not have any functional modifications.
Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
---
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
3 files changed, 56 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/8826/3
--
To view, visit http://gerrit.cloudera.org:8080/8826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
Gerrit-Change-Number: 8826
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [itests] a couple of new test utility functions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8826 )
Change subject: [itests] a couple of new test utility functions
......................................................................
[itests] a couple of new test utility functions
Moved GetServers[With,Without]Replica() utility test functions from
RaftConsensusNonVoterITest into the TabletServerIntegrationTestBase
class to start using them from other tests as well.
This changelist does not have any functional modifications.
Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
Reviewed-on: http://gerrit.cloudera.org:8080/8826
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
3 files changed, 56 insertions(+), 50 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f440f1f84a6af06b12ec22ac9f3da0163922125
Gerrit-Change-Number: 8826
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot