You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/14 10:24:28 UTC
[GitHub] [shardingsphere] jingshanglu opened a new issue #15405: Enhancements to proxy integration narayana
jingshanglu opened a new issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405
## Feature Request
**For English only**, other languages will not accept.
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Background
When using the proxy with narayana, we need to configure the `xaRecoveryNodes` attribute for the proxy (the instanceid of the current proxy is used by default), and this attribute can be modified through distsql. The `xaRecoveryNodes` attribute is instance-level and needs to be bound to the instance
### Describe the feature you would like.
- [ ] Store `xaRecoveryNodes` at the instance level
- [ ] use distsql to show all instanceid
- [ ] use distsql to modify `xaRecoveryNodes`
- [ ] Ensure that `TM` is properly reinitialized after `xaRecoveryNodes` is modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1078588334
> ALTER INSTANCE 127.0.0.1@3310 SET XA_RECOVERY_ID = 127.0.0.1@3308,127.0.0.1@3310;
127.0.0.1@3308 is not alive proxy instance.
Hi @jingshanglu , can we change the key to `XA_RECOVERY_NODES` :
```sql
ALTER INSTANCE 127.0.0.1@3310 SET XA_RECOVERY_NODES = 127.0.0.1@3308,127.0.0.1@3310;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1038941115
@jingshanglu the DistSQL to show all instanced is already exists : `SHOW INSTANCE LIST`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1038919400
>
The result of `SHOW INSTANCE LIST` is used to provide the user with the modified value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1077545271
@RaigorJiang Maybe we should support this sql
`ALTER INSTANCE 127.0.0.1@3310 SET XA_RECOVERY_ID = 127.0.0.1@3308,127.0.0.1@3310;`
`127.0.0.1@3308` is not alive proxy instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
lanchengx commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1081373094
@TeslaCN done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
RaigorJiang edited a comment on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1060140393
Hi @jingshanglu
I found the `xa_recovery_id` in the `ComputeNode`, so I plan to make the following adjustments:
- Added display of `XA_RECOVERY_ID` in `SHOW INSTANCE LIST`
- Added a DistSQL syntax to modify it:
`ALTER INSTANCE 10.x.x.xxx@3307 SET XA_RECOVERY_ID = xxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
soulasuna commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1062505089
@menghaoranss I can try `add Event when xaRecoveryId changed`, please assign to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN closed issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
TeslaCN closed issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1078590095
> > ALTER INSTANCE 127.0.0.1@3310 SET XA_RECOVERY_ID = 127.0.0.1@3308,127.0.0.1@3310;
> > 127.0.0.1@3308 is not alive proxy instance.
>
> Hi @jingshanglu , can we change the key to `XA_RECOVERY_NODES` :
>
> ```sql
> ALTER INSTANCE 127.0.0.1@3310 SET XA_RECOVERY_NODES = 127.0.0.1@3308,127.0.0.1@3310;
> ```
OK，i agree with this idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1060140393
Hi @jingshanglu
I found the `xa_recovery_id` in the `ComputeNode`, so I plan to make the following adjustments:
- Added display of `XA_RECOVERY_ID` in `SHOW INSTANCE LIST`
- Added a DistSQL syntax to modify it:
`ALTER INSTANCE 10.x.x.xxx@3307 SET XA_RECOVERY_ID xxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1081352220
Hi @jingshanglu @lanchengx
Any update here? Could we finish this in 5.1.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1081408941
> @TeslaCN done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #15405: Enhancements to proxy integration narayana
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #15405:
URL: https://github.com/apache/shardingsphere/issues/15405#issuecomment-1038916626
Well, for task 2, `SHOW INSTANCE LIST` can display all instance ids, can it meet the requirements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org