You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/28 07:04:05 UTC
[GitHub] [incubator-dolphinscheduler] zixi0825 opened a new pull request
#2327: #2282 fix workflow dependent bug
zixi0825 opened a new pull request #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327
## What is the purpose of the pull request
* This pull request fix the workflow depend bug*
## Brief change log
- *fix the bug that when a workflow adds a task, the dependent task will make an error*
## Verify this pull request
This pull request is code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2327:
#2282 fix workflow dependent bug
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327#issuecomment-605406829
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=h1) Report
> Merging [#2327](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/eef8bf4e6de199313499477ac6f8dbac1512f2da&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2327 +/- ##
============================================
- Coverage 31.07% 31.07% -0.01%
- Complexity 1708 1709 +1
============================================
Files 337 337
Lines 17679 17707 +28
Branches 2206 2215 +9
============================================
+ Hits 5494 5502 +8
- Misses 11623 11643 +20
Partials 562 562
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/worker/task/dependent/DependentExecute.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RlcGVuZGVudC9EZXBlbmRlbnRFeGVjdXRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/server/worker/task/dependent/DependentTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RlcGVuZGVudC9EZXBlbmRlbnRUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/service/process/ProcessService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `91.30% <0.00%> (-8.70%)` | `7.00% <0.00%> (-1.00%)` | |
| [...inscheduler/common/task/spark/SparkParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3BhcmsvU3BhcmtQYXJhbWV0ZXJzLmphdmE=) | `1.96% <0.00%> (-0.09%)` | `1.00% <0.00%> (ø%)` | |
| [...dolphinscheduler/server/worker/task/TaskProps.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tQcm9wcy5qYXZh) | `44.59% <0.00%> (+2.70%)` | `23.00% <0.00%> (+1.00%)` | |
| [...nscheduler/server/worker/task/shell/ShellTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NoZWxsL1NoZWxsVGFzay5qYXZh) | `77.77% <0.00%> (+13.62%)` | `6.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=footer). Last update [eef8bf4...9e26951](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] zixi0825 closed pull request #2327:
#2282 fix workflow dependent bug
Posted by GitBox <gi...@apache.org>.
zixi0825 closed pull request #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#2327: #2282 fix workflow dependent bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327#issuecomment-605406829
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=h1) Report
> Merging [#2327](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/eef8bf4e6de199313499477ac6f8dbac1512f2da&el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2327 +/- ##
============================================
- Coverage 31.07% 30.70% -0.38%
- Complexity 1708 1742 +34
============================================
Files 337 342 +5
Lines 17679 18120 +441
Branches 2206 2276 +70
============================================
+ Hits 5494 5564 +70
- Misses 11623 11987 +364
- Partials 562 569 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/worker/task/dependent/DependentExecute.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RlcGVuZGVudC9EZXBlbmRlbnRFeGVjdXRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/server/worker/task/dependent/DependentTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RlcGVuZGVudC9EZXBlbmRlbnRUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/service/process/ProcessService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../dolphinscheduler/common/process/ResourceInfo.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Byb2Nlc3MvUmVzb3VyY2VJbmZvLmphdmE=) | `42.85% <0.00%> (-57.15%)` | `2.00% <0.00%> (-1.00%)` | |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `56.22% <0.00%> (-23.53%)` | `67.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `91.30% <0.00%> (-8.70%)` | `7.00% <0.00%> (-1.00%)` | |
| [...inscheduler/common/task/flink/FlinkParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svZmxpbmsvRmxpbmtQYXJhbWV0ZXJzLmphdmE=) | `20.00% <0.00%> (-2.92%)` | `6.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `72.71% <0.00%> (-1.90%)` | `83.00% <0.00%> (ø%)` | |
| [...nscheduler/server/worker/task/sqoop/SqoopTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3Nxb29wL1Nxb29wVGFzay5qYXZh) | `31.81% <0.00%> (-1.52%)` | `3.00% <0.00%> (ø%)` | |
| ... and [35 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=footer). Last update [eef8bf4...17461fc](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#2327: #2282 fix workflow dependent bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327#issuecomment-605406829
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=h1) Report
> Merging [#2327](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/eef8bf4e6de199313499477ac6f8dbac1512f2da&el=desc) will **decrease** coverage by `0.39%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2327 +/- ##
============================================
- Coverage 31.07% 30.67% -0.40%
- Complexity 1708 1742 +34
============================================
Files 337 342 +5
Lines 17679 18120 +441
Branches 2206 2276 +70
============================================
+ Hits 5494 5559 +65
- Misses 11623 11987 +364
- Partials 562 574 +12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/worker/task/dependent/DependentExecute.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RlcGVuZGVudC9EZXBlbmRlbnRFeGVjdXRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/server/worker/task/dependent/DependentTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RlcGVuZGVudC9EZXBlbmRlbnRUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/service/process/ProcessService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../dolphinscheduler/common/process/ResourceInfo.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Byb2Nlc3MvUmVzb3VyY2VJbmZvLmphdmE=) | `42.85% <0.00%> (-57.15%)` | `2.00% <0.00%> (-1.00%)` | |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `56.22% <0.00%> (-23.53%)` | `67.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...inscheduler/common/task/flink/FlinkParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svZmxpbmsvRmxpbmtQYXJhbWV0ZXJzLmphdmE=) | `20.00% <0.00%> (-2.92%)` | `6.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `72.71% <0.00%> (-1.90%)` | `83.00% <0.00%> (ø%)` | |
| [...nscheduler/server/worker/task/sqoop/SqoopTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3Nxb29wL1Nxb29wVGFzay5qYXZh) | `31.81% <0.00%> (-1.52%)` | `3.00% <0.00%> (ø%)` | |
| [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `74.14% <0.00%> (-0.40%)` | `36.00% <0.00%> (ø%)` | |
| ... and [33 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=footer). Last update [eef8bf4...74624fa](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2327:
#2282 fix workflow dependent bug
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327#issuecomment-605424625
> > Merging [#2327](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/eef8bf4e6de199313499477ac6f8dbac1512f2da&el=desc) will **decrease** coverage by `0.37%`.
please fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#2327: #2282 fix workflow dependent bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327#issuecomment-605406829
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=h1) Report
> Merging [#2327](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/eef8bf4e6de199313499477ac6f8dbac1512f2da&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2327 +/- ##
=========================================
Coverage 31.07% 31.08%
- Complexity 1708 1710 +2
=========================================
Files 337 337
Lines 17679 17708 +29
Branches 2206 2217 +11
=========================================
+ Hits 5494 5504 +10
- Misses 11623 11646 +23
+ Partials 562 558 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/worker/task/dependent/DependentExecute.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RlcGVuZGVudC9EZXBlbmRlbnRFeGVjdXRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/server/worker/task/dependent/DependentTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2RlcGVuZGVudC9EZXBlbmRlbnRUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/service/process/ProcessService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...inscheduler/common/task/spark/SparkParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3BhcmsvU3BhcmtQYXJhbWV0ZXJzLmphdmE=) | `1.96% <0.00%> (-0.09%)` | `1.00% <0.00%> (ø%)` | |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `80.00% <0.00%> (ø)` | `15.00% <0.00%> (ø%)` | |
| [...dolphinscheduler/server/worker/task/TaskProps.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tQcm9wcy5qYXZh) | `44.59% <0.00%> (+2.70%)` | `23.00% <0.00%> (+1.00%)` | |
| [...nscheduler/server/worker/task/shell/ShellTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NoZWxsL1NoZWxsVGFzay5qYXZh) | `77.77% <0.00%> (+13.62%)` | `6.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=footer). Last update [eef8bf4...7c57a7e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong edited a comment on issue
#2327: #2282 fix workflow dependent bug
Posted by GitBox <gi...@apache.org>.
dailidong edited a comment on issue #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327#issuecomment-605424625
> Merging [#2327](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2327?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/eef8bf4e6de199313499477ac6f8dbac1512f2da&el=desc) will **decrease** coverage by `0.37%`.
please fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] feiyalun commented on a change in pull
request #2327: #2282 fix workflow dependent bug
Posted by GitBox <gi...@apache.org>.
feiyalun commented on a change in pull request #2327: #2282 fix workflow dependent bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2327#discussion_r399643451
##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/dependent/DependentExecute.java
##########
@@ -104,25 +105,29 @@ private DependResult calculateResultForTasks(DependentItem dependentItem,
dependentItem.getDefinitionId(), dateInterval.getStartTime(), dateInterval.getEndTime() );
return DependResult.FAILED;
}
+
if(dependentItem.getDepTasks().equals(Constants.DEPENDENT_ALL)){
- result = getDependResultByState(processInstance.getState());
- }else{
- TaskInstance taskInstance = null;
- List<TaskInstance> taskInstanceList = processService.findValidTaskListByProcessId(processInstance.getId());
+ List<TaskNode> taskNodes =
+ processService.getTaskNodeListByDefinitionId(dependentItem.getDefinitionId());
- for(TaskInstance task : taskInstanceList){
- if(task.getName().equals(dependentItem.getDepTasks())){
- taskInstance = task;
- break;
- }
- }
- if(taskInstance == null){
- // cannot find task in the process instance
- // maybe because process instance is running or failed.
- result = getDependResultByState(processInstance.getState());
+ if(taskNodes.size() == 0){
Review comment:
taskNodes. you think must not is empity ?? why write it is if( CollectionUtils.isNotEmpty(taskNodes)&&taskNodes.size() == 0){
/////
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services