You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2012/05/04 02:28:50 UTC
[jira] [Created] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Gregory Chanan created HBASE-5936:
-------------------------------------
Summary: Add Column-level PB-based calls to HMasterInterface
Key: HBASE-5936
URL: https://issues.apache.org/jira/browse/HBASE-5936
Project: HBase
Issue Type: Task
Components: ipc, master, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Fix For: 0.96.0
This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
This is for converting the column-level calls, i.e.:
addColumn
deleteColumn
modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287095#comment-13287095 ]
Hadoop QA commented on HBASE-5936:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530482/HBASE-5936-v6.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestHMasterRPCException
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2080//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2080//console
This message is automatically generated.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286208#comment-13286208 ]
Hudson commented on HBASE-5936:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #33 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/33/])
HBASE-5936 Add Column-level PB-based calls to HMasterInterface; REVERT (Revision 1344449)
HBASE-5936 Add Column-level PB-based calls to HMasterInterface (Revision 1344433)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-server/src/main/protobuf/Master.proto
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-server/src/main/protobuf/Master.proto
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5936:
----------------------------------
Attachment: HBASE-5936-v3.patch
* Attached HBASE-5936-v3.patch *
I haven't run this through the full test suite yet, let's see what hadoopQA says.
Makes the following changes from previous patch:
- Removed some dead code from WritableRpcEngine.java
- Converted the offline method used by hbck as well
- Fix the test case problems. The issue was that HConnectionManager was taking a remote exception (e.g. ServiceException) and throwing the underlying IOException. The problem is the function was declared as throwing a ServiceException, so you get a fun UndeclaredThrowableException and lose the actual underlying exception. Luckily, there were some test cases that checked the actual exception type. I suspect all the RPC conversions we've done had this problem. That said, I'm not sure if Jimmy's stuff relied on the old behavior, so let's see what hadoopQA says.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287859#comment-13287859 ]
Hudson commented on HBASE-5936:
-------------------------------
Integrated in HBase-TRUNK #2974 (See [https://builds.apache.org/job/HBase-TRUNK/2974/])
HBASE-5936 Addendum adds changes for TestHMasterRPCException that were missed in previous checkin (Revision 1345441)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: 5936-addendum-v2.txt, HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287855#comment-13287855 ]
Zhihong Yu commented on HBASE-5936:
-----------------------------------
Addendum v2 integrated to trunk.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: 5936-addendum-v2.txt, HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5936:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk. I ran the three failing tests locally and they passed for me w/ this patch applied. Thanks Gregory for your doggedness getting this in.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285975#comment-13285975 ]
Zhihong Yu commented on HBASE-5936:
-----------------------------------
I tried one of the tests listed above and got:
{code}
testExceptionFromCoprocessorWhenCreatingTable(org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove) Time elapsed: 0.247 sec <<< FAILURE!
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:92)
at org.junit.Assert.assertTrue(Assert.java:43)
at org.junit.Assert.assertTrue(Assert.java:54)
at org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove.testExceptionFromCoprocessorWhenCreatingTable(TestMasterCoprocessorExceptionWithRemove.java:191)
{code}
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5936:
----------------------------------
Attachment: HBASE-5936-v4.patch
* Added v4.patch *
Previous patch was missing this part that I mentioned:
"Removed some dead code from WritableRpcEngine.java"
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286936#comment-13286936 ]
Hadoop QA commented on HBASE-5936:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530432/HBASE-5936-v4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
org.apache.hadoop.hbase.master.TestHMasterRPCException
org.apache.hadoop.hbase.util.TestHBaseFsck
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2077//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2077//console
This message is automatically generated.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5936:
----------------------------------
Attachment: HBASE-5936-v6.patch
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287586#comment-13287586 ]
Gregory Chanan commented on HBASE-5936:
---------------------------------------
I ran these failed tests multiple times locally and they passed.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5936:
----------------------------------
Hadoop Flags: Reviewed (was: Incompatible change,Reviewed)
Status: Patch Available (was: Reopened)
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287813#comment-13287813 ]
Zhihong Yu commented on HBASE-5936:
-----------------------------------
I can easily reproduce one of the test failures seen on Jenkins (https://builds.apache.org/view/G-L/view/HBase/job/HBase-TRUNK/2972/testReport/org.apache.hadoop.hbase.master/TestHMasterRPCException/testRPCException/):
{code}
Failed tests: testRPCException(org.apache.hadoop.hbase.master.TestHMasterRPCException): Unexpected throwable: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
{code}
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287779#comment-13287779 ]
Hudson commented on HBASE-5936:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #36 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/36/])
HBASE-5936 Add Column-level PB-based calls to HMasterInterface (Revision 1345390)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/main/protobuf/Master.proto
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5936:
------------------------------
Attachment: 5936-addendum-v2.txt
The exception came out of HBaseRPC.getProxy() call.
Addendum v2 passes TestHMasterRPCException.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: 5936-addendum-v2.txt, HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285999#comment-13285999 ]
stack commented on HBASE-5936:
------------------------------
I backed it out Gregory.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285968#comment-13285968 ]
Gregory Chanan commented on HBASE-5936:
---------------------------------------
Stack, those test failures appear to be caused by this patch. There's something funky going on with the exception handling. Should I file a new JIRA?
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285984#comment-13285984 ]
stack commented on HBASE-5936:
------------------------------
@Gregory Yes please. I should have been less enthusiastic about commit. If you can't work on it today, I can back this out.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5936:
----------------------------------
Attachment: HBASE-5936-v5.patch
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287896#comment-13287896 ]
Hudson commented on HBASE-5936:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #37 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/37/])
HBASE-5936 Addendum adds changes for TestHMasterRPCException that were missed in previous checkin (Revision 1345441)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: 5936-addendum-v2.txt, HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287856#comment-13287856 ]
stack commented on HBASE-5936:
------------------------------
Thanks Ted.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: 5936-addendum-v2.txt, HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287852#comment-13287852 ]
stack commented on HBASE-5936:
------------------------------
That seems like easy enough to work around. Any chance of your taking a look Gregory? Separate issue? Thanks boss.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5936:
-------------------------
Attachment: HBASE-5936-v4.patch
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5936:
-------------------------
Status: Open (was: Patch Available)
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5936:
-------------------------
Resolution: Fixed
Hadoop Flags: Incompatible change,Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Gregory.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287792#comment-13287792 ]
Hudson commented on HBASE-5936:
-------------------------------
Integrated in HBase-TRUNK #2972 (See [https://builds.apache.org/job/HBase-TRUNK/2972/])
HBASE-5936 Add Column-level PB-based calls to HMasterInterface (Revision 1345390)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/main/protobuf/Master.proto
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286821#comment-13286821 ]
Zhihong Yu commented on HBASE-5936:
-----------------------------------
No Hadoop QA activity so far.
Probably you need to run the suite yourself.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286017#comment-13286017 ]
Gregory Chanan commented on HBASE-5936:
---------------------------------------
@stack: Sounds good. Working on fix now.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286814#comment-13286814 ]
Gregory Chanan commented on HBASE-5936:
---------------------------------------
I checked with Jimmy and he said the change looks good. Hopefully I managed to kick off HadoopQA again.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reopened HBASE-5936:
--------------------------
Let me just reopen this.... altogether. I'll back it out. You can add fix to a new version of the patch Gregory. Thanks.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286031#comment-13286031 ]
Hudson commented on HBASE-5936:
-------------------------------
Integrated in HBase-TRUNK #2956 (See [https://builds.apache.org/job/HBase-TRUNK/2956/])
HBASE-5936 Add Column-level PB-based calls to HMasterInterface (Revision 1344433)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-server/src/main/protobuf/Master.proto
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286847#comment-13286847 ]
Zhihong Yu commented on HBASE-5936:
-----------------------------------
Still no activity.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5936:
------------------------------
Attachment: (was: 5936-addendum.txt)
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5936:
------------------------------
Attachment: 5936-addendum.txt
Looks like the snippet from patch v6 for TestHMasterRPCException wasn't applied to trunk.
Addendum attached.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: 5936-addendum.txt, HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936-v5.patch, HBASE-5936-v6.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285305#comment-13285305 ]
Hadoop QA commented on HBASE-5936:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530121/HBASE-5936.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.master.TestRestartCluster
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2040//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2040//console
This message is automatically generated.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5936:
----------------------------------
Status: Patch Available (was: Open)
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286976#comment-13286976 ]
Gregory Chanan commented on HBASE-5936:
---------------------------------------
Looking at test failures. TestSplitTransactionOnCluster and TestHBaseFsck are fixed in upcoming version.
TestHMasterRPCException is tricky because is apparently relied on the old exception behavior that I removed.
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5936:
----------------------------------
Attachment: HBASE-5936.patch
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286081#comment-13286081 ]
Hudson commented on HBASE-5936:
-------------------------------
Integrated in HBase-TRUNK #2957 (See [https://builds.apache.org/job/HBase-TRUNK/2957/])
HBASE-5936 Add Column-level PB-based calls to HMasterInterface; REVERT (Revision 1344449)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-server/src/main/protobuf/Master.proto
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5936) Add Column-level PB-based calls to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5936:
-------------------------
Status: Patch Available (was: Open)
See if the just-done little dance triggers hadoopqa
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
> Key: HBASE-5936
> URL: https://issues.apache.org/jira/browse/HBASE-5936
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-5936-v3.patch, HBASE-5936-v4.patch, HBASE-5936-v4.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira