You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/09/15 08:02:34 UTC
[GitHub] matthiasblaesing commented on a change in pull request #877:
[NETBEANS-1074] Module Review servletjspapi
matthiasblaesing commented on a change in pull request #877: [NETBEANS-1074] Module Review servletjspapi
URL: https://github.com/apache/incubator-netbeans/pull/877#discussion_r217879039
##########
File path: enterprise/servletjspapi/nbproject/project.properties
##########
@@ -16,7 +16,7 @@
# under the License.
is.autoload=true
-release.external/servlet3.1-jsp2.3-api.jar=modules/ext/servlet3.1-jsp2.3-api.jar
+release.external/javax.servlet.jsp-api-2.3.3.jar=modules/ext/javax.servlet.jsp-api-2.3.3.jar
Review comment:
Please consider if a mapping:
```
release.external/javax.servlet.jsp-api-2.3.3.jar=modules/ext/servlet3.1-jsp2.3-api.jar
```
would be better. That way there would be no external change necessary. You could consider the file name a kind of API and by retaining the original name, you keep the API stable.
That way several of the other changes here are not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists