You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/16 03:35:30 UTC

[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4467: Remove allAckInSyncStateSet in GroupCommitRequest and use ackNums = -1 instead

tsunghanjacktsai commented on code in PR #4467:
URL: https://github.com/apache/rocketmq/pull/4467#discussion_r898661450


##########
common/src/main/java/org/apache/rocketmq/common/MixAll.java:
##########
@@ -77,6 +77,7 @@ public class MixAll {
     public static final long FIRST_SLAVE_ID = 1L;
     public static final long CURRENT_JVM_PID = getPID();
     public final static int UNIT_PRE_SIZE_FOR_MSG = 28;
+    public final static int ALL_ACK_IN_SYNC_STATE_SET_NUM = -1;

Review Comment:
   Would better just name it in ALL_ACK_IN_SYNC_STATE_SET without NUM since it's only a constant status. Adding NUM got a bit weird.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org