You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Andrew de Andrade (JIRA)" <ji...@apache.org> on 2015/02/04 01:59:34 UTC

[jira] [Updated] (THRIFT-2964) nodejs: move protocols and transports into separate files

     [ https://issues.apache.org/jira/browse/THRIFT-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew de Andrade updated THRIFT-2964:
--------------------------------------
    Attachment: 0001-nodejs-break-apart-transport.js-and-protocol.js.patch

Randy, Here is the patch. 

Broke apart transport.js and protocol.js. DRYed up the creation of clients (except the multiplex createClient method). Fixed some inconsistent indentation, and ported some JSDoc in the lib/js to its equivalent in lib/nodejs.

Insofar as how things work, nothing was changed. This is just a general refactor around breaking apart protocols and transports.

> nodejs: move protocols and transports into separate files
> ---------------------------------------------------------
>
>                 Key: THRIFT-2964
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2964
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>            Reporter: Andrew de Andrade
>            Priority: Minor
>         Attachments: 0001-nodejs-break-apart-transport.js-and-protocol.js.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)