You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Kristian Rosenvold <kr...@apache.org> on 2015/01/12 09:36:52 UTC

[compress] ConcurrentJarCreator

We had somewhat of a discussion regarding this class on the maven dev
list over the weekend, some people wanted this code inside
commons-compress:

Code is here: https://github.com/krosenvold/plexus-archiver/blob/2.x/src/main/java/org/codehaus/plexus/archiver/zip/ConcurrentJarCreator.java

I have been thinking a little about this, and my personal preference
is maybe it would be better for a subsequent release; I think it
probably belongs in c-c. But I also think the exact api of this class
is still a bit immature, and it will probably evolve a fair bit more
as I take full consequence of the new api inside maven code. I'm sure
ant code would have the same challenges.

We could of course add it with a huge warning about unstable api etc.
the "problem" right now is that the code in c-c is more like a
low-level toolbox. The knowledge of how to create a final well-formed
jar file is inside ConcurrentJarCreator.


Kristian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] JIRA permissions for Kristian Rosenvold

Posted by Kristian Rosenvold <kr...@apache.org>.
Sorry; all is ok. The asf jira has a slightly different config than
the one I'm used to.

Kristian


2015-01-23 10:46 GMT+01:00 Kristian Rosenvold <kr...@apache.org>:
> Can you check that you did the right thing, Mark ? It seems like I
> have even less permissions now; I can't even edit "own issues" any
> more...?
>
> Kristian
>
>
> 2015-01-23 10:13 GMT+01:00 Mark Thomas <ma...@apache.org>:
>> On 23/01/2015 09:10, Stefan Bodewig wrote:
>>> On 2015-01-23, luc wrote:
>>>
>>>> Le 2015-01-23 04:00, sebb a écrit :
>>>>> On 22 January 2015 at 23:55, sebb <se...@gmail.com> wrote:
>>>>>> On 20 January 2015 at 16:26, Stefan Bodewig <bo...@apache.org>
>>>>>> wrote:
>>>
>>>>>>> JIRA Admins for Commons are Phil, Luc and Mark Struberg.
>>
>> Wrong Mark.
>>
>> I've just added Kristian to the Committer, Contributor, Developer and
>> User roles for the Commons Category (which should include all Commons
>> components).
>>
>> Mark
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] JIRA permissions for Kristian Rosenvold

Posted by Kristian Rosenvold <kr...@apache.org>.
Can you check that you did the right thing, Mark ? It seems like I
have even less permissions now; I can't even edit "own issues" any
more...?

Kristian


2015-01-23 10:13 GMT+01:00 Mark Thomas <ma...@apache.org>:
> On 23/01/2015 09:10, Stefan Bodewig wrote:
>> On 2015-01-23, luc wrote:
>>
>>> Le 2015-01-23 04:00, sebb a écrit :
>>>> On 22 January 2015 at 23:55, sebb <se...@gmail.com> wrote:
>>>>> On 20 January 2015 at 16:26, Stefan Bodewig <bo...@apache.org>
>>>>> wrote:
>>
>>>>>> JIRA Admins for Commons are Phil, Luc and Mark Struberg.
>
> Wrong Mark.
>
> I've just added Kristian to the Committer, Contributor, Developer and
> User roles for the Commons Category (which should include all Commons
> components).
>
> Mark
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] JIRA permissions for Kristian Rosenvold

Posted by sebb <se...@gmail.com>.
On 23 January 2015 at 09:13, Mark Thomas <ma...@apache.org> wrote:
> On 23/01/2015 09:10, Stefan Bodewig wrote:
>> On 2015-01-23, luc wrote:
>>
>>> Le 2015-01-23 04:00, sebb a écrit :
>>>> On 22 January 2015 at 23:55, sebb <se...@gmail.com> wrote:
>>>>> On 20 January 2015 at 16:26, Stefan Bodewig <bo...@apache.org>
>>>>> wrote:
>>
>>>>>> JIRA Admins for Commons are Phil, Luc and Mark Struberg.
>
> Wrong Mark.

Not according to JIRA, see for example:

https://issues.apache.org/jira/plugins/servlet/project-config/VALIDATOR/roles

But that is presumably only listing project admins?

> I've just added Kristian to the Committer, Contributor, Developer and
> User roles for the Commons Category (which should include all Commons
> components).

What karma is needed to update the Commons Category?
Obviously that would be a lot easier than updating each project
separately (which I suspect many of us have karma for).

> Mark
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] JIRA permissions for Kristian Rosenvold

Posted by Mark Thomas <ma...@apache.org>.
On 23/01/2015 09:10, Stefan Bodewig wrote:
> On 2015-01-23, luc wrote:
> 
>> Le 2015-01-23 04:00, sebb a écrit :
>>> On 22 January 2015 at 23:55, sebb <se...@gmail.com> wrote:
>>>> On 20 January 2015 at 16:26, Stefan Bodewig <bo...@apache.org>
>>>> wrote:
> 
>>>>> JIRA Admins for Commons are Phil, Luc and Mark Struberg.

Wrong Mark.

I've just added Kristian to the Committer, Contributor, Developer and
User roles for the Commons Category (which should include all Commons
components).

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] JIRA permissions for Kristian Rosenvold

Posted by Stefan Bodewig <bo...@apache.org>.
On 2015-01-23, luc wrote:

> Le 2015-01-23 04:00, sebb a écrit :
>> On 22 January 2015 at 23:55, sebb <se...@gmail.com> wrote:
>>> On 20 January 2015 at 16:26, Stefan Bodewig <bo...@apache.org>
>>> wrote:

>>>> JIRA Admins for Commons are Phil, Luc and Mark Struberg.

> As far as I know, I don't have administration rights on our JIRA
> project.

https://issues.apache.org/jira/plugins/servlet/project-config/COMPRESS/roles

is what I used, so maybe you just don't know about you power? :-)

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] JIRA permissions for Kristian Rosenvold

Posted by luc <lu...@spaceroots.org>.
Le 2015-01-23 04:00, sebb a écrit :
> On 22 January 2015 at 23:55, sebb <se...@gmail.com> wrote:
>> On 20 January 2015 at 16:26, Stefan Bodewig <bo...@apache.org> 
>> wrote:
>>> On 2015-01-20, Kristian Rosenvold wrote:
>>> 
>>>> Btw it still seems like my JIRA karma is a bit weak ?
>>> 
>>> I'm not sure what you are missing, but I am sure I cannot provide it 
>>> :-)
>>> 
>>> JIRA Admins for Commons are Phil, Luc and Mark Struberg.

As far as I know, I don't have administration rights on our JIRA 
project.

Luc

>> 
>> Has this been fixed?
>> 
>> According to INFRA-9009 we now use roles for JIRA karma.
> 
> Just found more info here:
> 
> https://cwiki.apache.org/confluence/display/INFRA/Role+Based+JIRA+Authorization
> 
>> These are project based. Groups are "no longer used" though Commons
>> does appear to be using them.
>> 
>> I cannot update the commons-group, nor can I see who is in the 
>> commons-group.
>> (So I don't know if Kristian has been added)
>> 
>> I think that would need someone with Infra karma.
>> 
>> It looks like I can add people to individual Commons projects.
>> For example, I added Kristian to Compress.
>> Maybe that is enough for now?
>> 
>>> Stefan
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] JIRA permissions for Kristian Rosenvold

Posted by sebb <se...@gmail.com>.
On 22 January 2015 at 23:55, sebb <se...@gmail.com> wrote:
> On 20 January 2015 at 16:26, Stefan Bodewig <bo...@apache.org> wrote:
>> On 2015-01-20, Kristian Rosenvold wrote:
>>
>>> Btw it still seems like my JIRA karma is a bit weak ?
>>
>> I'm not sure what you are missing, but I am sure I cannot provide it :-)
>>
>> JIRA Admins for Commons are Phil, Luc and Mark Struberg.
>
> Has this been fixed?
>
> According to INFRA-9009 we now use roles for JIRA karma.

Just found more info here:

https://cwiki.apache.org/confluence/display/INFRA/Role+Based+JIRA+Authorization

> These are project based. Groups are "no longer used" though Commons
> does appear to be using them.
>
> I cannot update the commons-group, nor can I see who is in the commons-group.
> (So I don't know if Kristian has been added)
>
> I think that would need someone with Infra karma.
>
> It looks like I can add people to individual Commons projects.
> For example, I added Kristian to Compress.
> Maybe that is enough for now?
>
>> Stefan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] JIRA permissions for Kristian Rosenvold

Posted by sebb <se...@gmail.com>.
On 20 January 2015 at 16:26, Stefan Bodewig <bo...@apache.org> wrote:
> On 2015-01-20, Kristian Rosenvold wrote:
>
>> Btw it still seems like my JIRA karma is a bit weak ?
>
> I'm not sure what you are missing, but I am sure I cannot provide it :-)
>
> JIRA Admins for Commons are Phil, Luc and Mark Struberg.

Has this been fixed?

According to INFRA-9009 we now use roles for JIRA karma.
These are project based. Groups are "no longer used" though Commons
does appear to be using them.

I cannot update the commons-group, nor can I see who is in the commons-group.
(So I don't know if Kristian has been added)

I think that would need someone with Infra karma.

It looks like I can add people to individual Commons projects.
For example, I added Kristian to Compress.
Maybe that is enough for now?

> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[ALL] JIRA permissions for Kristian Rosenvold

Posted by Stefan Bodewig <bo...@apache.org>.
On 2015-01-20, Kristian Rosenvold wrote:

> Btw it still seems like my JIRA karma is a bit weak ?

I'm not sure what you are missing, but I am sure I cannot provide it :-)

JIRA Admins for Commons are Phil, Luc and Mark Struberg.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [compress] ConcurrentJarCreator

Posted by Kristian Rosenvold <kr...@apache.org>.
Yup I'm done, added a small blurb in changes.xml in r1653282.

Btw it still seems like my JIRA karma is a bit weak ?

Kristian


2015-01-20 16:00 GMT+01:00 Stefan Bodewig <bo...@apache.org>:
> On 2015-01-12, Kristian Rosenvold wrote:
>
>> We had somewhat of a discussion regarding this class on the maven dev
>> list over the weekend, some people wanted this code inside
>> commons-compress:
>
>> Code is here: https://github.com/krosenvold/plexus-archiver/blob/2.x/src/main/java/org/codehaus/plexus/archiver/zip/ConcurrentJarCreator.java
>
>> I have been thinking a little about this, and my personal preference
>> is maybe it would be better for a subsequent release;
>
> Agreed.
>
> Do you consider your work in "parallel jar" creation done for the scope
> of Compress 1.10?  If so, could you please add a blurb in changes.xml?
>
> I'd like to prepare a first RC of 1.10 this week unless anything is
> still missing.
>
> Cheers
>
>         Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [compress] ConcurrentJarCreator

Posted by Stefan Bodewig <bo...@apache.org>.
On 2015-01-12, Kristian Rosenvold wrote:

> We had somewhat of a discussion regarding this class on the maven dev
> list over the weekend, some people wanted this code inside
> commons-compress:

> Code is here: https://github.com/krosenvold/plexus-archiver/blob/2.x/src/main/java/org/codehaus/plexus/archiver/zip/ConcurrentJarCreator.java

> I have been thinking a little about this, and my personal preference
> is maybe it would be better for a subsequent release;

Agreed.

Do you consider your work in "parallel jar" creation done for the scope
of Compress 1.10?  If so, could you please add a blurb in changes.xml?

I'd like to prepare a first RC of 1.10 this week unless anything is
still missing.

Cheers

        Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org