You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/03 07:03:26 UTC

[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #299: Bugfix: ClientSessionImpl#syncSettings should not block asynchronous worker thread

codecov-commenter commented on PR #299:
URL: https://github.com/apache/rocketmq-clients/pull/299#issuecomment-1336100404

   # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/299?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#299](https://codecov.io/gh/apache/rocketmq-clients/pull/299?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4eaa00e) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/8aa0ee1c066c890edacb1a728ad8b07d61397a2f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8aa0ee1) will **increase** coverage by `0.22%`.
   > The diff coverage is `73.68%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #299      +/-   ##
   ============================================
   + Coverage     34.78%   35.01%   +0.22%     
   - Complexity      646      650       +4     
   ============================================
     Files           220      220              
     Lines         11489    11491       +2     
     Branches        276      277       +1     
   ============================================
   + Hits           3996     4023      +27     
   + Misses         7244     7215      -29     
   - Partials        249      253       +4     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | java | `61.45% <73.68%> (+0.67%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/rocketmq/client/java/impl/ClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50SW1wbC5qYXZh) | `52.03% <63.63%> (+8.68%)` | :arrow_up: |
   | [...e/rocketmq/client/java/impl/ClientSessionImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50U2Vzc2lvbkltcGwuamF2YQ==) | `78.02% <80.00%> (-1.33%)` | :arrow_down: |
   | [...e/rocketmq/client/java/impl/ClientManagerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50TWFuYWdlckltcGwuamF2YQ==) | `72.90% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org