You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ctakes.apache.org by st...@apache.org on 2013/02/07 00:25:52 UTC

svn commit: r1443273 - /incubator/ctakes/trunk/ctakes-core/src/main/java/org/apache/ctakes/core/knowtator/KnowtatorXMLParser.java

Author: stevenbethard
Date: Wed Feb  6 23:25:52 2013
New Revision: 1443273

URL: http://svn.apache.org/viewvc?rev=1443273&view=rev
Log:
Fixes warning and improves logged warnings for KnowtatorXMLParser

Modified:
    incubator/ctakes/trunk/ctakes-core/src/main/java/org/apache/ctakes/core/knowtator/KnowtatorXMLParser.java

Modified: incubator/ctakes/trunk/ctakes-core/src/main/java/org/apache/ctakes/core/knowtator/KnowtatorXMLParser.java
URL: http://svn.apache.org/viewvc/incubator/ctakes/trunk/ctakes-core/src/main/java/org/apache/ctakes/core/knowtator/KnowtatorXMLParser.java?rev=1443273&r1=1443272&r2=1443273&view=diff
==============================================================================
--- incubator/ctakes/trunk/ctakes-core/src/main/java/org/apache/ctakes/core/knowtator/KnowtatorXMLParser.java (original)
+++ incubator/ctakes/trunk/ctakes-core/src/main/java/org/apache/ctakes/core/knowtator/KnowtatorXMLParser.java Wed Feb  6 23:25:52 2013
@@ -163,7 +163,7 @@ public class KnowtatorXMLParser {
     final Element child = element.getChild(cname);
     if (child == null) {
       String xml = this.xmlOutputter.outputString(element);
-      LOGGER.warning(String.format("no %s for %s", cname, xml));
+      LOGGER.warning(String.format("no child <%s> for %s", cname, xml));
     }
     return new Option<Element>(child);
   }
@@ -172,7 +172,7 @@ public class KnowtatorXMLParser {
     final String value = element.getAttributeValue(attname);
     if (value == null) {
       String xml = this.xmlOutputter.outputString(element);
-      LOGGER.warning(String.format("no %s for %s", attname, xml));
+      LOGGER.warning(String.format("no attribute %s for %s", attname, xml));
     }
     return new Option<String>(value);
   }
@@ -198,7 +198,7 @@ public class KnowtatorXMLParser {
   }
 
   private static class Option<T> implements Iterable<T> {
-    private T value;
+    T value;
 
     public Option(T value) {
       this.value = value;