DO NOT REPLY [Bug 8167] New: - --with-module does not build MODULE_DIRS correctly

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8167>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8167

--with-module does not build MODULE_DIRS correctly

           Summary: --with-module does not build MODULE_DIRS correctly
           Product: Apache httpd-2.0
           Version: 2.0.35
          Platform: All
        OS/Version: Other
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Other Modules
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: chrisd@pearsoncmg.com


When using --with-module=module-type:module-file, if the module-type is not the
same as any of the modules enabled using --enable-module (or similar means),
then the MODULE_DIRS and MODULE_CLEANDIRS variables in the build/config_vars.mk
file are not properly created.  The module-type is missing from MODULE_DIRS and
is present in MODULE_CLEANDIRS, which prevents the additional module from
compiling with make.

My current solution is to edit the configure script and save $modtype into a
variable following the block that deals with --with-module.  Then, after the
block that deals with mod_so and before the lines that begin with
APACHE_VAR_SUBST="$APACHE_VAR_SUBST progname", I loop over $MODULE_DIRS (and
$MODULE_CLEANDIRS) and add (and remove) the additional $modtype, but only if it
has not been added to $MODULE_DIRS already by a preceding configuration block.

The following diff shows my current solution (hopefully the newlines will
display properly):

8993d8992
<     extra_module_dir="$modtype"
11278,11298d11276
<   if test ! -z "$extra_module_dir"; then
<     extra_module_flag="0"
<     for i in $MODULE_DIRS; do
<       if test "x$i" = "x$extra_module_dir"; then
<         extra_module_flag="1"
<         break
<       fi
<     done
<     if test $extra_module_flag = "0"; then
<       echo "  adding \"$extra_module_dir\" to MODULE_DIRS"
<       MODULE_DIRS="$MODULE_DIRS $extra_module_dir"
<       extra_module_cleandirs=""
<       for i in $MODULE_CLEANDIRS; do
<         if test "x$i" != "x$extra_module_dir"; then
<           extra_module_cleandirs="$extra_module_cleandirs $i"
<         fi
<       done
<       echo "  removing \"$extra_module_dir\" from MODULE_CLEANDIRS"
<       MODULE_CLEANDIRS="$extra_module_cleandirs"
<     fi
<   fi

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org