You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Klaus Ma (JIRA)" <ji...@apache.org> on 2015/11/24 07:02:11 UTC

[jira] [Assigned] (MESOS-3963) Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

     [ https://issues.apache.org/jira/browse/MESOS-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Ma reassigned MESOS-3963:
-------------------------------

    Assignee: Klaus Ma

> Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"
> ---------------------------------------------------------------------------------
>
>                 Key: MESOS-3963
>                 URL: https://issues.apache.org/jira/browse/MESOS-3963
>             Project: Mesos
>          Issue Type: Bug
>          Components: fetcher
>            Reporter: Klaus Ma
>            Assignee: Klaus Ma
>            Priority: Minor
>              Labels: newbie
>
> According to the google code style, the using should be used in internal namespace in header files. Grep the header files, only fetcher.hpp deserved a path.
> {quote}
> You may use a using-declaration anywhere in a .cc file (including in the global namespace), and in functions, methods, classes, or within internal namespaces in .h files.
> Do not use using-declarations in .h files except in explicitly marked internal-only namespaces, because anything imported into a namespace in a .h file becomes part of the public API exported by that file.
> {code}
> // OK in .cc files.
> // Must be in a function, method, internal namespace, or
> // class in .h files.
> using ::foo::bar;
> {code}
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)