You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/25 02:48:43 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #16647: Move FABs base Security Manager into Airflow.
jhtimmins opened a new pull request #16647:
URL: https://github.com/apache/airflow/pull/16647
As one of the first steps in refactoring Airflow's usage of the FAB security manager (and eventually removing FAB altogether), copy FAB's base SecurityManager classes into Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins merged pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
jhtimmins merged pull request #16647:
URL: https://github.com/apache/airflow/pull/16647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #16647:
URL: https://github.com/apache/airflow/pull/16647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#issuecomment-868180550
I see, thanks for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#issuecomment-868179295
> Do we want to keep FAB in the name? If we end up removing Flask-Appbuilder altogether, the name reference may feel confusing to newcomers.
I'm refactoring it in pieces, so I plan to change the naming in a PR that's coming shortly. For now though, it exactly matches the FAB architecture and references FAB models/concepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins merged pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
jhtimmins merged pull request #16647:
URL: https://github.com/apache/airflow/pull/16647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#issuecomment-924911197
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on a change in pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on a change in pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#discussion_r660104110
##########
File path: airflow/www/fab_security/manager.py
##########
@@ -0,0 +1,1952 @@
+import base64
Review comment:
Thanks Kaxil, I've added the license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#issuecomment-898775016
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#discussion_r659166308
##########
File path: airflow/www/fab_security/manager.py
##########
@@ -0,0 +1,1952 @@
+import base64
Review comment:
Need to add Apache-license same as below:
https://github.com/apache/airflow/blob/d4a056647e0f4bf76d1139853917149b907beb2d/airflow/config_templates/default_webserver_config.py#L1-L17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #16647:
URL: https://github.com/apache/airflow/pull/16647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#issuecomment-868178150
Do we want to keep FAB in the name? If we end up removing Rlask-Appbuilder altogether, the name reference may feel confusing to newcomers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#discussion_r692128122
##########
File path: NOTICE
##########
@@ -12,3 +12,11 @@ This product contains a modified portion of 'Hue' developed by Cloudera, Inc.
(https://github.com/cloudera/hue/).
* Copyright 2009-2017 Cloudera Inc.
+
+
+Flask App Builder:
+-----
Review comment:
```suggestion
Flask App Builder:
------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#discussion_r660479455
##########
File path: airflow/www/security.py
##########
@@ -32,6 +31,7 @@
from airflow.security import permissions
from airflow.utils.log.logging_mixin import LoggingMixin
from airflow.utils.session import provide_session
+from airflow.www.fab_security.sqla.manager import SecurityManager
Review comment:
Is the plan to customize and tweak the content of these files?
If not, It maybe makes more sens to put them under airflow/_vendor/
Or maybe even if we do plan on doing that, if the content is "as upstream" now, maybe it still makes sense to put in that location until we do make such a change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #16647:
URL: https://github.com/apache/airflow/pull/16647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #16647:
URL: https://github.com/apache/airflow/pull/16647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins edited a comment on pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
jhtimmins edited a comment on pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#issuecomment-868179295
> Do we want to keep FAB in the name? If we end up removing Flask-Appbuilder altogether, the name reference may feel confusing to newcomers.
@uranusjr I'm refactoring it in pieces, so I plan to change the naming in a PR that's coming shortly. For now though, it exactly matches the FAB architecture and references FAB models/concepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#discussion_r660479455
##########
File path: airflow/www/security.py
##########
@@ -32,6 +31,7 @@
from airflow.security import permissions
from airflow.utils.log.logging_mixin import LoggingMixin
from airflow.utils.session import provide_session
+from airflow.www.fab_security.sqla.manager import SecurityManager
Review comment:
Is the plan to customize and tweak the content of these files?
If not, It maybe makes more sens to put them under airflow/_vendor/
Or maybe even if we do plan on doing that, if the content is "as upstream" now, maybe it still makes sense to put in that location until we do make such a change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on a change in pull request #16647: Move FABs base Security Manager into Airflow.
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on a change in pull request #16647:
URL: https://github.com/apache/airflow/pull/16647#discussion_r660104110
##########
File path: airflow/www/fab_security/manager.py
##########
@@ -0,0 +1,1952 @@
+import base64
Review comment:
Thanks Kaxil, I've added the license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org