You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/09 14:09:02 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #208: Update workflows
hanahmily opened a new pull request, #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208
* Rearrange steps of workflows
* Introduce dependency review
Signed-off-by: Gao Hongtao <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] Superskyyy commented on a diff in pull request #208: Improve workflows and building tools
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on code in PR #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208#discussion_r1018549142
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
See a case here https://github.com/apache/skywalking/actions/runs/3368331192/jobs/5588961894
Fix (the timeout variable) is documented here.
https://github.com/actions/cache/blob/main/workarounds.md#cache-segment-restore-timeout
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
Hello, the timeout setting is not related to OAP itself but GitHub actions.
It should be used at any GitHub action step which involves downloading artifact previously stored by the actions/cache@3. Otherwise, it might get stuck for an hour. For example, in the OAP repo case it's used to retrieve the cached infra-e2e build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on a diff in pull request #208: Improve workflows and building tools
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208#discussion_r1018532819
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
Check whether you need the timeout setting, https://github.com/apache/skywalking/pull/9894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #208: Update workflows
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208#issuecomment-1308830504
# [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#208](https://codecov.io/gh/apache/skywalking-banyandb/pull/208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2edad4c) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/99606f5f688a897bc0d5e984b00f8c7710e35170?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (99606f5) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2edad4c differs from pull request most recent head 3932a58. Consider uploading reports for the commit 3932a58 to get more accurate results
```diff
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 44.84% 44.84%
=======================================
Files 84 84
Lines 8500 8500
=======================================
Hits 3812 3812
Misses 4354 4354
Partials 334 334
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] Superskyyy commented on a diff in pull request #208: Improve workflows and building tools
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on code in PR #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208#discussion_r1018551749
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
sorry thought I clicked comment but was pending :|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #208: Improve workflows and building tools
Posted by GitBox <gi...@apache.org>.
hanahmily merged PR #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on a diff in pull request #208: Improve workflows and building tools
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208#discussion_r1018544595
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
It isn't. It is GitHub action tool parameter. That segment mean cache segment.
I didn't find the original post, it was in other discussions. @Superskyyy Could you share the source?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #208: Improve workflows and building tools
Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208#discussion_r1018540303
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
@Superskyyy Do we need this patch here? It looks like an OAP-related variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] kezhenxu94 commented on a diff in pull request #208: Improve workflows and building tools
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #208:
URL: https://github.com/apache/skywalking-banyandb/pull/208#discussion_r1018545606
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
https://github.com/apache/skywalking/pull/9863#issuecomment-1298596785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org