You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2010/08/26 19:04:43 UTC

svn commit: r989824 - in /subversion/trunk: configure.ac get-deps.sh

Author: hwright
Date: Thu Aug 26 17:04:43 2010
New Revision: 989824

URL: http://svn.apache.org/viewvc?rev=989824&view=rev
Log:
Bump the recommended SQLite version, due to a potential database corruption
bug in previous versions.

* get-deps.sh
  (SQLITE_VERSION): Bump to 3.7.2.

* configure.ac
  (SQLITE_RECOMMENDED_VER): Bump to 3.7.2.

Modified:
    subversion/trunk/configure.ac
    subversion/trunk/get-deps.sh

Modified: subversion/trunk/configure.ac
URL: http://svn.apache.org/viewvc/subversion/trunk/configure.ac?rev=989824&r1=989823&r2=989824&view=diff
==============================================================================
--- subversion/trunk/configure.ac (original)
+++ subversion/trunk/configure.ac Thu Aug 26 17:04:43 2010
@@ -153,7 +153,7 @@ SVN_FIND_APACHE(20020903)
 
 dnl Search for SQLite
 SQLITE_MINIMUM_VER="3.4.0"
-SQLITE_RECOMMENDED_VER="3.6.17"
+SQLITE_RECOMMENDED_VER="3.7.2"
 SQLITE_URL="http://www.sqlite.org/sqlite-amalgamation-${SQLITE_RECOMMENDED_VER}.tar.gz"
 SVN_LIB_SQLITE(${SQLITE_MINIMUM_VER}, ${SQLITE_RECOMMENDED_VER},
                ${SQLITE_URL})

Modified: subversion/trunk/get-deps.sh
URL: http://svn.apache.org/viewvc/subversion/trunk/get-deps.sh?rev=989824&r1=989823&r2=989824&view=diff
==============================================================================
--- subversion/trunk/get-deps.sh (original)
+++ subversion/trunk/get-deps.sh Thu Aug 26 17:04:43 2010
@@ -28,7 +28,7 @@ APR_UTIL=apr-util-1.3.9
 NEON=neon-0.29.0
 SERF=serf-0.6.1
 ZLIB=zlib-1.2.5
-SQLITE_VERSION=3.6.20
+SQLITE_VERSION=3.7.2
 SQLITE=sqlite-amalgamation-$SQLITE_VERSION
 
 HTTPD=httpd-2.2.14

Re: svn commit: r989824 - in /subversion/trunk: configure.ac get-deps.sh

Posted by Julian Foad <ju...@wandisco.com>.
On Thu, 2010-08-26, hwright@apache.org wrote:
> Log:
> Bump the recommended SQLite version, due to a potential database corruption
> bug in previous versions.

That sounds more serious than it is to us.  We don't appear to be using
"incremental vacuum" anywhere (there's no mention in our trunk source
tree), so that bug can't bite us.

The bug is described very briefly at
<http://www.sqlite.org/releaselog/3_7_2.html> and the "news" page has a
fuller human-friendly description of the severity:
<http://www.sqlite.org/news.html>.

Would you mention this in the log msg?

It's fine to recommend this version, of course.

- Julian


> * get-deps.sh
>   (SQLITE_VERSION): Bump to 3.7.2.
> 
> * configure.ac
>   (SQLITE_RECOMMENDED_VER): Bump to 3.7.2.
> 
> Modified:
>     subversion/trunk/configure.ac
>     subversion/trunk/get-deps.sh
> 
> Modified: subversion/trunk/configure.ac
> URL: http://svn.apache.org/viewvc/subversion/trunk/configure.ac?rev=989824&r1=989823&r2=989824&view=diff
> ==============================================================================
> --- subversion/trunk/configure.ac (original)
> +++ subversion/trunk/configure.ac Thu Aug 26 17:04:43 2010
> @@ -153,7 +153,7 @@ SVN_FIND_APACHE(20020903)
>  
>  dnl Search for SQLite
>  SQLITE_MINIMUM_VER="3.4.0"
> -SQLITE_RECOMMENDED_VER="3.6.17"
> +SQLITE_RECOMMENDED_VER="3.7.2"
>  SQLITE_URL="http://www.sqlite.org/sqlite-amalgamation-${SQLITE_RECOMMENDED_VER}.tar.gz"
>  SVN_LIB_SQLITE(${SQLITE_MINIMUM_VER}, ${SQLITE_RECOMMENDED_VER},
>                 ${SQLITE_URL})
> 
> Modified: subversion/trunk/get-deps.sh
> URL: http://svn.apache.org/viewvc/subversion/trunk/get-deps.sh?rev=989824&r1=989823&r2=989824&view=diff
> ==============================================================================
> --- subversion/trunk/get-deps.sh (original)
> +++ subversion/trunk/get-deps.sh Thu Aug 26 17:04:43 2010
> @@ -28,7 +28,7 @@ APR_UTIL=apr-util-1.3.9
>  NEON=neon-0.29.0
>  SERF=serf-0.6.1
>  ZLIB=zlib-1.2.5
> -SQLITE_VERSION=3.6.20
> +SQLITE_VERSION=3.7.2
>  SQLITE=sqlite-amalgamation-$SQLITE_VERSION
>  
>  HTTPD=httpd-2.2.14

Re: svn commit: r989824 - in /subversion/trunk: configure.ac get-deps.sh

Posted by Julian Foad <ju...@wandisco.com>.
On Thu, 2010-08-26, hwright@apache.org wrote:
> Log:
> Bump the recommended SQLite version, due to a potential database corruption
> bug in previous versions.

That sounds more serious than it is to us.  We don't appear to be using
"incremental vacuum" anywhere (there's no mention in our trunk source
tree), so that bug can't bite us.

The bug is described very briefly at
<http://www.sqlite.org/releaselog/3_7_2.html> and the "news" page has a
fuller human-friendly description of the severity:
<http://www.sqlite.org/news.html>.

Would you mention this in the log msg?

It's fine to recommend this version, of course.

- Julian


> * get-deps.sh
>   (SQLITE_VERSION): Bump to 3.7.2.
> 
> * configure.ac
>   (SQLITE_RECOMMENDED_VER): Bump to 3.7.2.
> 
> Modified:
>     subversion/trunk/configure.ac
>     subversion/trunk/get-deps.sh
> 
> Modified: subversion/trunk/configure.ac
> URL: http://svn.apache.org/viewvc/subversion/trunk/configure.ac?rev=989824&r1=989823&r2=989824&view=diff
> ==============================================================================
> --- subversion/trunk/configure.ac (original)
> +++ subversion/trunk/configure.ac Thu Aug 26 17:04:43 2010
> @@ -153,7 +153,7 @@ SVN_FIND_APACHE(20020903)
>  
>  dnl Search for SQLite
>  SQLITE_MINIMUM_VER="3.4.0"
> -SQLITE_RECOMMENDED_VER="3.6.17"
> +SQLITE_RECOMMENDED_VER="3.7.2"
>  SQLITE_URL="http://www.sqlite.org/sqlite-amalgamation-${SQLITE_RECOMMENDED_VER}.tar.gz"
>  SVN_LIB_SQLITE(${SQLITE_MINIMUM_VER}, ${SQLITE_RECOMMENDED_VER},
>                 ${SQLITE_URL})
> 
> Modified: subversion/trunk/get-deps.sh
> URL: http://svn.apache.org/viewvc/subversion/trunk/get-deps.sh?rev=989824&r1=989823&r2=989824&view=diff
> ==============================================================================
> --- subversion/trunk/get-deps.sh (original)
> +++ subversion/trunk/get-deps.sh Thu Aug 26 17:04:43 2010
> @@ -28,7 +28,7 @@ APR_UTIL=apr-util-1.3.9
>  NEON=neon-0.29.0
>  SERF=serf-0.6.1
>  ZLIB=zlib-1.2.5
> -SQLITE_VERSION=3.6.20
> +SQLITE_VERSION=3.7.2
>  SQLITE=sqlite-amalgamation-$SQLITE_VERSION
>  
>  HTTPD=httpd-2.2.14