You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2023/01/04 08:38:18 UTC
[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1586: feat: support global rules
AlinsRan opened a new pull request, #1586:
URL: https://github.com/apache/apisix-ingress-controller/pull/1586
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1586: feat: support global rules
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1586:
URL: https://github.com/apache/apisix-ingress-controller/pull/1586#issuecomment-1370625245
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1586](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53a8b26) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/486b46abd1c9665005e83036433af213aaa28f21?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (486b46a) will **decrease** coverage by `0.25%`.
> The diff coverage is `12.30%`.
```diff
@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
- Coverage 41.44% 41.18% -0.26%
==========================================
Files 87 88 +1
Lines 7420 7485 +65
==========================================
+ Hits 3075 3083 +8
- Misses 3990 4043 +53
- Partials 355 359 +4
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...providers/apisix/translation/apisix\_global\_rule.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X2dsb2JhbF9ydWxlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/providers/apisix/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `0.00% <ø> (ø)` | |
| [...ess/translation/annotations/plugins/http\_method.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL2Fubm90YXRpb25zL3BsdWdpbnMvaHR0cF9tZXRob2QuZ28=) | `81.81% <ø> (ø)` | |
| [pkg/providers/translation/context.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy90cmFuc2xhdGlvbi9jb250ZXh0Lmdv) | `80.95% <0.00%> (-8.53%)` | :arrow_down: |
| [pkg/providers/utils/manifest.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy91dGlscy9tYW5pZmVzdC5nbw==) | `41.17% <27.58%> (-1.63%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on pull request #1586: feat: ApisixGlobalRule support global rules
Posted by GitBox <gi...@apache.org>.
AlinsRan commented on PR #1586:
URL: https://github.com/apache/apisix-ingress-controller/pull/1586#issuecomment-1378475217
> Code overall LGTM
>
> one question, how to deal with conflicts between ApisixGlobalRule and ApisixClusterConfig?
There are two conflicts:
1. Construct the same name
2. Different objects use the same plugin.
For 1, ApisixGlobalRule is a namespace-level resource that constructs objects based on namespace-name, and there is no identical name.
For 2, use plugins in different global-rules objects, APISIX does not restrict this. (Of course, we need to point it out in the documentation, or recommend users to use ApisixGlobalRule)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1586: feat: ApisixGlobalRule support global rules
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #1586:
URL: https://github.com/apache/apisix-ingress-controller/pull/1586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org