You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/04/25 01:35:40 UTC
Review Request 33541: DRILL-2855: Fix invalid result issues with
StreamingAggBatch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33541/
-----------------------------------------------------------
Review request for drill and Steven Phillips.
Repository: drill-git
Description
-------
Make sure for every incoming record:
1. Add to workspace
2. Increment index in current incoming batch
3. Set previousIndex properly
Diffs
-----
pom.xml 8c9f09e
Diff: https://reviews.apache.org/r/33541/diff/
Testing
-------
Ran SF 100 tests which were failing earlier due to verification issue are passing now.
Thanks,
Venki Korukanti
Re: Review Request 33541: DRILL-2855: Fix invalid result issues with
StreamingAggBatch
Posted by Steven Phillips <sp...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33541/#review81733
-----------------------------------------------------------
Ship it!
Ship It!
- Steven Phillips
On April 24, 2015, 11:36 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33541/
> -----------------------------------------------------------
>
> (Updated April 24, 2015, 11:36 p.m.)
>
>
> Review request for drill and Steven Phillips.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Make sure for every incoming record:
> 1. Add to workspace
> 2. Increment index in current incoming batch
> 3. Set previousIndex properly
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggTemplate.java bf27187
>
> Diff: https://reviews.apache.org/r/33541/diff/
>
>
> Testing
> -------
>
> Ran SF 100 tests which were failing earlier due to verification issue are passing now.
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33541: DRILL-2855: Fix invalid result issues with
StreamingAggBatch
Posted by Suhas Satish <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33541/#review81576
-----------------------------------------------------------
Ship it!
Ship It!
- Suhas Satish
On April 24, 2015, 11:36 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33541/
> -----------------------------------------------------------
>
> (Updated April 24, 2015, 11:36 p.m.)
>
>
> Review request for drill and Steven Phillips.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Make sure for every incoming record:
> 1. Add to workspace
> 2. Increment index in current incoming batch
> 3. Set previousIndex properly
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggTemplate.java bf27187
>
> Diff: https://reviews.apache.org/r/33541/diff/
>
>
> Testing
> -------
>
> Ran SF 100 tests which were failing earlier due to verification issue are passing now.
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33541: DRILL-2855: Fix invalid result issues with
StreamingAggBatch
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33541/
-----------------------------------------------------------
(Updated April 24, 2015, 11:36 p.m.)
Review request for drill and Steven Phillips.
Repository: drill-git
Description
-------
Make sure for every incoming record:
1. Add to workspace
2. Increment index in current incoming batch
3. Set previousIndex properly
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggTemplate.java bf27187
Diff: https://reviews.apache.org/r/33541/diff/
Testing
-------
Ran SF 100 tests which were failing earlier due to verification issue are passing now.
Thanks,
Venki Korukanti